Review Request: Fix exporting to non-native formats on Windows, e.g. HTML

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107388/
-----------------------------------------------------------

(Updated Nov. 20, 2012, 9:22 a.m.)


Review request for Calligra, Boudewijn Rempt and C. Boemann.


Changes
-------

Add a detailed explanation for the workaround as comment


Description
-------

Currently exporting to non-native formats (File/Export...) fails on Windows, because the temporary files are empty on disk.

    The fix follows approach of bf47fed5ead06f2128abf042897f86bab39cf333 ,
    by destructing the KTemporaryFile object used to get a unique temporary
    file name right after its creation again, to avoid having two file handlers
    on the same file, which seems somehow to prevent synching the bytes written
    by the filter, which ATM opens its own new file handler, by the name of
    the temporary file (as KoFilterChain can be only queried for filenames,
    KoDocuments or KoStores).
    
    Real fix might be to use the KTemporaryFile objects also by the filters,
    instead of having them open the same file on their own again.
    Another fix might be to find out which flags have to be used in Windows on
    opening the files, to prevent this behaviour (unless these details are hidden
    away by the Qt abstraction).
    
    Also fixes a possible crash on Windows in KoFilterChain::outputFileHelper(...):
    m_outputTempFile was accessed even when it might be set to 0 a few lines before


Diffs (updated)
-----

  libs/main/KoFilterChain.cpp b952588 

Diff: http://git.reviewboard.kde.org/r/107388/diff/


Testing
-------

Run a build with this patch and exported a few files from Calligra Words to HTML, no longer empty output.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121120/552a9f51/attachment.htm>