Review Request: <dc:language> metadata

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107371/#review22186
-----------------------------------------------------------


Found one small issue.  I'm going to actually test the patch while you fix that. 


filters/words/epub/EpubFile.cpp
<http://git.reviewboard.kde.org/r/107371/#comment17082>

    I think we should still use english ("en") as a fallback / default value if the metadata.value("language") return an empty string.


- Inge Wallin


On Nov. 18, 2012, 8:14 p.m., mojtaba shahi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107371/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2012, 8:14 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Add <dc:language> to meta.xml and then add it to epub (opf file).
> 
> 
> Diffs
> -----
> 
>   filters/words/epub/EpubFile.cpp c07e7a9 
>   libs/main/KoDocumentInfo.cpp 77b5992 
>   libs/main/KoDocumentInfoDlg.cpp 920c05c 
>   libs/main/koDocumentInfoAboutWidget.ui a5133ed 
> 
> Diff: http://git.reviewboard.kde.org/r/107371/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> mojtaba shahi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121118/ea391634/attachment.htm>