Review Request: Fix saving of Author info for non-default and non-anonymous case

C. Boemann cbr at boemann.dk
Sun Nov 18 13:56:46 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107366/#review22168
-----------------------------------------------------------

Ship it!


yes please backport

- C. Boemann


On Nov. 18, 2012, 1:52 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107366/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2012, 1:52 p.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> KoConfigAuthorPage::apply() uses "Author-" and not "Author" as prefix:
>         KConfigGroup cgs(&authorGroup, "Author-" + d->combo->itemText(i));
> 
> So KoDocumentInfo needs to use the same prefix to fetch the data of the author in KoDocumentInfo::saveParameters() :)
> 
> Okay to backport to 2.6?
> 
> 
> Diffs
> -----
> 
>   libs/main/KoDocumentInfo.cpp 77b5992 
> 
> Diff: http://git.reviewboard.kde.org/r/107366/diff/
> 
> 
> Testing
> -------
> 
> Saved and loaded a document with a non-default author profile.
> Then changed the non-default author profile and saved and loaded the document again.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121118/1821cb81/attachment.htm>


More information about the calligra-devel mailing list