Review Request: Move fileproperties plugin out of libs/main into tools/properties (and make it work again)

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107353/#review22159
-----------------------------------------------------------

Ship it!


I agree with the move. Have you checked with the author, David Faure, whether he had any reason to keep it in libs/main? 

- Boudewijn Rempt


On Nov. 17, 2012, 2:58 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107353/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2012, 2:58 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Did you know that Calligra also installs a fileproperties dialog plugin, to show the general meta data and the author info?
> 
> I did not, until I wondered where those pages in the fileproperties dialog plugin came from (e.g. select "Properties" on a ODF file in Dolphin and select the "General" or "Last saved by" tabs).
> This plugin better lives next to its cousin, the thumbnailer plugin, in the tools part of the sources tree (even if developing tools and user tools ideally would be in separate tree branches in the sources).
> So the attached patch moves all files belonging to this plugin into the new dir "tools/properties" (any better name proposal?). Additionally it makes it also work again, by teaching KoDocumentInfoDlg to also deal with a KoDocumentInfo object without an attached KoDocument, like in the case of the fileproperties plugin, and turning off the entries in the "General" tab which are redundant in the fileproperties dialog (path & type).
> 
> Okay to backport to 2.6?
> 
> Setting the Authors profile does not work correctly currently, but that is a separate problem I will look next into. The dialog shows at least any set Author info correctly.
> 
> 
> Diffs
> -----
> 
>   libs/main/CMakeLists.txt ae68a2b 
>   libs/main/KoDocInfoPropsFactory.cpp c1d89b9 
>   libs/main/KoDocumentInfoDlg.cpp 920c05c 
>   libs/main/koDocumentInfoAboutWidget.ui a5133ed 
>   libs/main/kodocinfopropspage.desktop 5acfbc0 
>   tools/CMakeLists.txt b0eb900 
>   tools/properties/CMakeLists.txt PRE-CREATION 
>   tools/properties/KoDocInfoPropsFactory.cpp PRE-CREATION 
>   tools/properties/calligradocinfopropspage.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107353/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121118/48da36e8/attachment.htm>