Review Request: fix signal/slot connections for KoDocumentRdf's semanticObject* signals

C. Boemann cbr at boemann.dk
Thu Nov 15 11:04:42 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107335/#review22027
-----------------------------------------------------------

Ship it!


looks correct

As for removing rdf again. Now I don't think we actually need to remove that, but I have removed the user visible stuff as much as I could, because we are still evolving, but mostly because we are lacking some useful/relevant user interface.

- C. Boemann


On Nov. 15, 2012, 10:27 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107335/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2012, 10:27 a.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> The semanticObject* signals of KoDocumentRdf had a change of the first parameter, from KoRdfSemanticItem* to hKoRdfSemanticItem. But some signal/slots connections were not adapted to this.
> Attached patch fixes those connections (and slots).
> 
> (BTW, RDF support seems still not complete or at least user-friendly, perhaps it should be moved to a feature branch again and only in master, once it is useful?)
> 
> 
> Diffs
> -----
> 
>   libs/main/rdf/KoDocumentRdfEditWidget.h 24c624a 
>   libs/main/rdf/KoDocumentRdfEditWidget.cpp 39d4fc1 
>   words/part/KWView.cpp 23d37a4 
>   words/part/dockers/KWRdfDocker.h 6c80e6f 
>   words/part/dockers/KWRdfDocker.cpp eea8588 
> 
> Diff: http://git.reviewboard.kde.org/r/107335/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121115/ffa8f880/attachment.htm>


More information about the calligra-devel mailing list