Review Request: libs/vectorimage

C. Boemann cbo at boemann.dk
Thu Nov 15 11:01:19 GMT 2012


On Monday 12 November 2012 19:04:25 Stuart Dickson wrote:
> A single library for managing EMF, SVM and WMF files.
> 
> I have submitted commits to the branch: libs-vectorimage-stuartmd-forreview
> Only the last three are relevant to the libs/vectorimage work - the diff
> may be generated with the call:
> git diff c55ec6499c5ead6d6a9b434651ab31f92d8b0b8b
> 
> 
> In reviewing master branch, it was determined that the problem building
> the epub export filter lay in the way it was trying to use the vector
> image libraries already present in plugins/vectorshape and
> filters/kolibwmf. (This problem may have only really manifested on
> Windows, owing to the way it handles shared libraries).
> 
> There had already been a suggestion that, as there was already some
> awkward coupling of plugins, and filters and knowledge of the location
> of the sources required, that moving the library code for EMF, SVM and
> WMF vector file formats into their own library would be the best way
> forward.
> 
> This patch creates the library and makes the necessary changes to its
> dependents and has been tested to function on the Windows platform.
> 
> 
> Regards
> Stuart
> 
> 
> 
> -- Stuart Dickson
> // KO GmbH http://kogmbh.com/legal/
> _______________________________________________
> calligra-devel mailing list
> calligra-devel at kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel
Have compiled and it works for me too




More information about the calligra-devel mailing list