Need help with reviewing and testing the KoToolManager changes

[Dmitry Kazakov]

Hi!

Some time ago I've done a patch [0] for the KoToolManager, which fixes the
deactivation of tools while switching the input device. This patch is
completely necessary for fixing the bug 298584 in Krita, because otherwise
Krita will not know when to finish the action of the tool.

Alongside with the deactivation, the patch also allows to disconnect the
actions of the previous tool properly and fixes initialization of the
status bar text for the tool. Without this patch, if you work with two
tools (e.g. Text tool and Brush tool) associated to two different devices,
the test in the status bar will be mixed.

One more bug which is fixed by the patch affects all the Calligra
application when they work in Multiple Views mode. If you assign two
different tools to two devices, then create a new view, then when switching
the devices, the tools will be switched in the initial view instead of a
new one. The selection decorations will be shown wrongly as well. This
happens because the canvasData object is not switched properly (the link to
the new KoCanvasControllerWidget is not established). This patch fixes this
bug as well.

Could you please test and/or review this patch so I could merge it to
master and, if possible, to calligra/2.6 ? You can test it either by
directly applying the patch from the reviewboard or by just checking out my
branch: krita-new-move-tool-kazakov

I tested this patch with Krita, Karbon, Flow and Words and found no
regressions.


[0] - https://git.reviewboard.kde.org/r/107205/
[1] - https://bugs.kde.org/show_bug.cgi?id=298584
-- 
Dmitry Kazakov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121112/e23da1a1/attachment.htm>