Review Request: autocorrect config file lookup change

[Laurent Montel]

> On Nov. 6, 2012, 6:04 p.m., Laurent Montel wrote:
> > plugins/textediting/autocorrection/Autocorrect.cpp, line 707
> > <http://git.reviewboard.kde.org/r/107229/diff/1/?file=93886#file93886line707>
> >
> >     You never breaks here ?
> >     So you will read a lot of file no ?
> 
> C. Boemann wrote:
>     yes that is the point - I want to first read the general kde wide file and then the calligra specific file.
>     
>     I could also revert your original patch and just read the calligra one
>     
>     the point is we need af file with the calligra specifics

"The special tags in the calligra supplied config files where never found" which special tags?

global file and calligra file is the same (installed from l10n) So What is the problem ?


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107229/#review21494
-----------------------------------------------------------


On Nov. 6, 2012, 5:54 p.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107229/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2012, 5:54 p.m.)
> 
> 
> Review request for Calligra and Laurent Montel.
> 
> 
> Description
> -------
> 
> The special tags in the calligra supplied config files where never found
> 
> So I've changed it so we first look up the general files and then the calligra specific files on top
> 
> A problem I see is that the general contents is never really used with my approach if we afterwards find a calligra special file
> 
> So a better suggestion is appreciated
> 
> 
> Diffs
> -----
> 
>   plugins/textediting/autocorrection/Autocorrect.h 5b76121 
>   plugins/textediting/autocorrection/Autocorrect.cpp 53fdee6 
> 
> Diff: http://git.reviewboard.kde.org/r/107229/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121106/891d2b31/attachment.htm>