Review Request: write entry in manifest for thumbnail file

Commit Hook null at kde.org
Tue Nov 6 14:58:28 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106941/#review21489
-----------------------------------------------------------


This review has been submitted with commit a190b201ac13d0544c6f88f21f826a42c3500ad7 by C. Boemann to branch master.

- Commit Hook


On Oct. 18, 2012, 10:41 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106941/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2012, 10:41 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> For some undocumented reason there is no entry written for the thumbnail file.
> 
> I could not see a reason why this is not done. In opposite, http://odf-validator2.rhcloud.com/odf-validator2/ complained about this missing entry. And files from LO always have this manifest entry.
> 
> Okay to also backport to 2.5 branch?
> 
> 
> Diffs
> -----
> 
>   libs/main/KoDocument.cpp dac99c7 
> 
> Diff: http://git.reviewboard.kde.org/r/106941/diff/
> 
> 
> Testing
> -------
> 
> LO 3.5 loaded the file fine, roundtrips with Calligra Words also are fine.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121106/5c59a0e6/attachment.htm>


More information about the calligra-devel mailing list