Review request: undo stack not cleaned on saving

[Dag]

Mandag den 5. november 2012 17:03:00 skrev C. Boemann:
> On Monday 05 November 2012 16:46:26 Dag wrote:
> > Mandag den 5. november 2012 16:35:51 skrev C. Boemann:
> > > On Monday 05 November 2012 16:26:06 Dag wrote:
> > > > Reviewboard refuses my patch...
> > > > 
> > > > The result is that [modified] indication is not in sync with file
> > > > content, so user may accidently loose data.
> > > 
> > > how do you see the problem?
> > 
> > Make 3 changes
> > Undo one
> > Save -> modified reset
> > Undo -> modified set
> > Redo  -> still modified (should not be modified)
> > Undo all changes -> modified reset (Should still be modified
> > 
> > But: It *might* be that my last review request caused this, although I
> > cannot find any place the stack was cleaned.
> > 
> > Let look a bit closer on this tomorrow, have to run now.
> 
> Okay I do see some issues when i try to do as you say - not completely the
> same, but definitely not right either
> 
> But after applying your patch it seems to be working correctly for me, so I
> say: Ship it, and please back port it too.
Ahh, found the culprit, it was lost in the dcoument/part split
Comitted.
> _______________________________________________
> calligra-devel mailing list
> calligra-devel at kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel
-- 
Mvh.
Dag Andersen