Review Request: Autosave only triggered on first change.

Boudewijn Rempt boud at valdyas.org
Mon Nov 5 13:12:02 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107206/#review21435
-----------------------------------------------------------


Looks good to me, also for 2.5.

- Boudewijn Rempt


On Nov. 5, 2012, 1:03 p.m., Dag Andersen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107206/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2012, 1:03 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Autosave only triggered on first change.
> 
> This patch exchanges the setDcoumentClean() public slot with private slot slotUndoStackIndexChanged(),
> and connects the latter to the indexChanged() signal of the undo stack.
> 
> The slot calls setModify on *all* undo/redo actions on the undo stack. This is needed to re-start the autosave timer.
> 
> Backport?
> 
> 
> This addresses bug 309574.
>     http://bugs.kde.org/show_bug.cgi?id=309574
> 
> 
> Diffs
> -----
> 
>   libs/main/KoDocument.h 17fe006 
>   libs/main/KoDocument.cpp dac99c7 
> 
> Diff: http://git.reviewboard.kde.org/r/107206/diff/
> 
> 
> Testing
> -------
> 
> Tested on sheets
> 
> 
> Thanks,
> 
> Dag Andersen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121105/ec11727f/attachment.htm>


More information about the calligra-devel mailing list