[calligra] plugins/textshape/dialogs: use flat buttons in the textshape docker

C. Boemann cbo at boemann.dk
Sun Nov 4 13:51:34 GMT 2012


On Sunday 04 November 2012 14:14:08 Friedrich W. H. Kossebau wrote:
> Am Sonntag, 4. November 2012, 13:32:36 schrieb Sven Langkamp:
> > Git commit cc10e194166f5c63cf5fb546a9c432e655f84bd8 by Sven 
Langkamp.
> > Committed on 04/11/2012 at 13:30.
> > Pushed by langkamp into branch 'master'.
> > 
> > use flat buttons in the textshape docker
> > BUG:308865
> > REVIEW:107190
> > 
> > M  +57   -9    plugins/textshape/dialogs/SimpleCharacterWidget.ui
> > M  +36   -0    plugins/textshape/dialogs/SimpleInsertWidget.ui
> > M  +64   -9    plugins/textshape/dialogs/SimpleParagraphWidget.ui
> > M  +70   -7    plugins/textshape/dialogs/SimpleTableWidget.ui
> > 
> > 
http://commits.kde.org/calligra/cc10e194166f5c63cf5fb546a9c432e655f84bd8
> > 
> > diff --git a/plugins/textshape/dialogs/SimpleCharacterWidget.ui
> > b/plugins/textshape/dialogs/SimpleCharacterWidget.ui index
> > 0b6cf2a..d4a67e2 100644
> > --- a/plugins/textshape/dialogs/SimpleCharacterWidget.ui
> > +++ b/plugins/textshape/dialogs/SimpleCharacterWidget.ui
> > @@ -7,7 +7,7 @@
> > 
> >      <x>0</x>
> >      <y>0</y>
> >      <width>303</width>
> > 
> > -    <height>67</height>
> > +    <height>72</height>
> > 
> >     </rect>
> >    
> >    </property>
> >    <property name="sizePolicy">
> > 
> > @@ -40,57 +40,105 @@
> > 
> >       </item>
> >       <item row="2" column="0">
> >       
> >        <widget class="QToolButton" name="bold">
> > 
> > +       <property name="iconSize">
> > +        <size>
> > +         <width>16</width>
> > +         <height>16</height>
> > +        </size>
> > +       </property>
> 
> Instead of hardcoding the size, is there anything speaking against using
> IconSize(KIconLoader::Small) (from KIconLoader)?
> 
> While that cannot be used in ui files and has to be done manually in the
> code (or?) it still allows the user to adapt the size to her/his monitor
> properties (think Retina display) and keeps the kdelibs-based programs 
in
> sync wrt look.
> 
> I think this would be the better solution here.
> 
Actually this part should just not be there, then it will default to a small

at least afaik



More information about the calligra-devel mailing list