Review Request: Kexi MainWindow fullscreen feature.

[Jaroslaw Staniek]

On 30 May 2012 01:53, Dimitrios Tanis <jtanis at tanisfood.gr> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105105/
>   Review request for Calligra, Jarosław Staniek and Adam Pigg.
> By Dimitrios Tanis.
>
> *Updated May 29, 2012, 11:53 p.m.*
> Description
>
> Kexi MainWindow fullscreen feature.
>
> Kexi fullscreen is implemented for Mainwindow, serving better
> manipulation in small factor screens (eg netbooks). Feature is
> accessible both using shortcuts and at launch from console.
>
> CCBUG: 298880
>
> PS. It is invoked via F11 (firefox style) or Standard Shortcut ctrl+shift+f
>
>   Testing
>
> Works for KexiMainWindow
>
>   Diffs
>
>    - kexi/main/startup/KexiStartup.cpp
>    (f2e8d32c40224aed7f17b9d51309d4faa9840707)
>    - kexi/main/KexiMainWindow_p.h
>    (db5c6448f49c67645c45e3f75590a2a2372a5180)
>    - kexi/main/KexiMainWindow.h (3e4aeff500112ea425e1c60ec45e47b2f5be5109)
>    - kexi/main/KexiMainWindow.cpp
>    (3bef113b21611e24f1d26114a6a190d3677c42f5)
>    - kexi/core/kexistartupdata.cpp
>    (60d0d637b2fd6fe7b585bd95f4767081d7167def)
>    - kexi/core/kexistartupdata.h
>    (7b43fdc4b4d6291f6ada3af7649883fe8d84349f)
>    - kexi/core/kexicmdlineargs.h
>    (b7579b9c9fb589acfad3eada50e2438a8aa5800d)
>
> View Diff <http://git.reviewboard.kde.org/r/105105/diff/>
> Screenshots (updated)
> [image: Kexi Fullscreen Feature]<http://git.reviewboard.kde.org/r/105105/s/577/>
>



Replying here because ReviewBoard is so broken today.


1. kexi/core/kexistartupdata.h:85

    /*! \return true is Kexi started fullscreen.

typo: is -> if

    Open an issue

2. kexi/core/kexistartupdata.h:87

    bool forcedFullscreen() const;

-> forcedFullScreen()


3. kexi/main/KexiMainWindow.cpp:887

    d->action_window_fullscreen = KStandardAction::fullScreen(this,
SLOT(toggleFullScreen(bool)), this, ac);

We want this action in global collection too, so this is missing:
ac->addAction("full_screen", d->action_window_fullscreen);


-- 
regards / pozdrawiam, Jaroslaw Staniek
 http://www.linkedin.com/in/jstaniek
 Kexi & Calligra (kexi-project.org, identi.ca/kexi, calligra-suite.org)
 KDE Software Development Platform on MS Windows (windows.kde.org)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120530/493bb809/attachment.htm>