Review Request: Ability to add image lists

[C. Boemann]

> On May 24, 2012, 10:53 p.m., C. Boemann wrote:
> > Maybe it's because the image i try to use is to big but i can't get it to work. no image is showing

Ahh it's because the size default to 0x0 and doesn't change with the image i select. Try to figure out a saner default size

Other than that it seems to work and the code looks nice

The dialog is getting really crowded, but let's tackle that some other time


- C.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105033/#review14148
-----------------------------------------------------------


On May 24, 2012, 6:30 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105033/
> -----------------------------------------------------------
> 
> (Updated May 24, 2012, 6:30 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Currently we have the ability to load and save image lists and not create new ones. With this patch we add the ability to add new image lists.
> 
> This review request partially fixes bug 298061. 
> 
> 
> This addresses bug 298061.
>     http://bugs.kde.org/show_bug.cgi?id=298061
> 
> 
> Diffs
> -----
> 
>   libs/kotext/commands/ChangeListCommand.cpp 501e381 
>   libs/kotext/styles/KoListLevelProperties.h ea08c9a 
>   libs/kotext/styles/KoListLevelProperties.cpp 8bc97ac 
>   libs/textlayout/ListItemsHelper.cpp cd7abd3 
>   plugins/pictureshape/PictureTool.cpp b46f05a 
>   plugins/textshape/TextShape.h 24285c7 
>   plugins/textshape/TextShape.cpp dc3bbbb 
>   plugins/textshape/TextTool.cpp ea97a06 
>   plugins/textshape/dialogs/ParagraphBulletsNumbers.h f8c4100 
>   plugins/textshape/dialogs/ParagraphBulletsNumbers.cpp c2936dc 
>   plugins/textshape/dialogs/ParagraphBulletsNumbers.ui 5458a3e 
>   plugins/textshape/dialogs/ParagraphGeneral.h 3cf9824 
>   plugins/textshape/dialogs/ParagraphGeneral.cpp 2fdb272 
>   plugins/textshape/dialogs/ParagraphSettingsDialog.h 0919f5e 
>   plugins/textshape/dialogs/ParagraphSettingsDialog.cpp 4ee3a34 
> 
> Diff: http://git.reviewboard.kde.org/r/105033/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gopalakrishna Bhat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120524/be8efdc1/attachment.htm>