Review Request: Renaming style and add new style

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104962/#review14147
-----------------------------------------------------------


we are getting close :)


plugins/textshape/dialogs/StyleManager.cpp
<http://git.reviewboard.kde.org/r/104962/#comment11192>

    hmm this should be the first test not the second



plugins/textshape/dialogs/StyleManager.cpp
<http://git.reviewboard.kde.org/r/104962/#comment11193>

    you should clear those lists at this point



plugins/textshape/dialogs/StylesModel.cpp
<http://git.reviewboard.kde.org/r/104962/#comment11194>

    please add space between if and (


- C. Boemann


On May 24, 2012, 10:37 p.m., mojtaba shahi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104962/
> -----------------------------------------------------------
> 
> (Updated May 24, 2012, 10:37 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> a new review for adding new style and renamimg styles
> 
> 
> Diffs
> -----
> 
>   plugins/textshape/dialogs/CharacterGeneral.h eed6a02 
>   plugins/textshape/dialogs/CharacterGeneral.cpp c951b27 
>   plugins/textshape/dialogs/ParagraphGeneral.h 3cf9824 
>   plugins/textshape/dialogs/ParagraphGeneral.cpp 2fdb272 
>   plugins/textshape/dialogs/StyleManager.h 44dff97 
>   plugins/textshape/dialogs/StyleManager.cpp c318dd7 
>   plugins/textshape/dialogs/StyleManagerDialog.h 56e36b4 
>   plugins/textshape/dialogs/StyleManagerDialog.cpp d423ae0 
>   plugins/textshape/dialogs/StylesModel.h 53c0225 
>   plugins/textshape/dialogs/StylesModel.cpp 3b03f1b 
> 
> Diff: http://git.reviewboard.kde.org/r/104962/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> mojtaba shahi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120524/391308a1/attachment.htm>