Review Request: Mark-up all icon-ids with macros for easy extraction (monster patch for first feedback)

Friedrich W. H. Kossebau kossebau at kde.org
Thu May 24 22:13:35 BST 2012 


> On May 24, 2012, 7:33 p.m., Jarosław Staniek wrote:
> > I think "iconName" be better than "iconId". Almost always id suggests numerical value...
> 
> Jarosław Staniek wrote:
>     BTW, I say that because you made changes like that to Kexi API, and left some other places in Kexi where iconName is used.

Okay, will use "iconName", is also consistent with existing naming scheme in kdelibs.

Just for the record: I would not agree to that id means usually numerical value, perhaps only for people with database background? :)


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104810/#review14139
-----------------------------------------------------------


On May 1, 2012, 4:01 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104810/
> -----------------------------------------------------------
> 
> (Updated May 1, 2012, 4:01 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> It is all but easy to get an overview which icons are used in Calligra. E.g. to check if the icon is part of the minimum version of the oxygen icon-set that is named as dependency for Calligra (ATM implicitely oxygen icon-set 4.3, as part of KDE 4.3).
> 
> I put down my thoughts in the blog post http://frinring.wordpress.com/2012/04/26/herding-your-programs-icons-how/ . During the WE I gave it a try to see if that could work out. Well, kind of does, at least would for me. How do you like the approach? See CaIcon.h for a(n incomplete) draft for the macros (used Ca as prefix, more Calligra-like for me then the historical prefix Ko, but do not mind). I tried to model it after the i18n* calls.
> 
> Idea is that normal icon-ids are used as const char*, QString property or directly with a KIcon call. For all three usages there should be the options to say a) "alright, use this icon"
> b) "would like another icon, for now use this one" -> wanted
> c) "definitely need a not yet existing icon here" -> needed
> (meh, reversed the wanted and needed in the patch, but you get the idea).
> Additionally it would be nice to give a comment, so e.g. the kind of icon wanted can be more described and that would also end up in the list of icons extracted, so there is no need to go and search near the extracted wanted/needed-icon for comments how the icon should be like.
> 
> And there also direct usages of icon-ids with SmallIcon and DesktopIcon, so there are two macros for these as well. Would need to get the Wanted and Needed variants as well, for completeness.
> 
> What is missing currently:
> * scripts to extract all the icon-ids from the markup. And also from all other places, like desktop and UI files
> * a list of the icons in the oxygen icon-set that is the minimal dependency
> * a way to get all icons installed with Calligra itself
> 
> But now I want your feedback to learn if you like this approach at all and want it in Calligra. After all it has small disadvantages, like that the usage of the macros cannot be enforced but need to be taken care of. And for non-C++ code this approach fails, so far no idea what to do there without run-time costs.
> 
> So, continue this path, or is it a dead-end with the Calligra devs? :)
> 
> 
> The patch includes also three other things which perhaps should be done as separate commits in any case?
> 
> a) fixes for the wrong usage of K/QIcon vs. pixmap (from incomplete Qt3->Qt4 porting): Q/KIcon does not have a real size, it's more kind of a factory for whatever pixmap size it is asked for, so just loading a certain icon pixmap and setting that to a KIcon/QIcon is useless, as the widget which takes the icon might request a different size. So e.g. passing a SmallIcon("icon-foo") to a button which takes a QIcon can result in badly scaled icons instead of loading the most perfect size match from the icon-set.
> 
> b) removes lots of unneeded kiconloader.h includes.
> 
> c) renames the property "icon" to "iconId" for some classes, to make it clear in the code that the property is just about the id string, not a K/QIcon instance (would "iconName" be better perhaps?)
> 
> 
> Diffs
> -----
> 
>   CaIcon.h PRE-CREATION 
>   braindump/plugins/stateshape/StateShapeFactory.cpp 782eaa5 
>   braindump/plugins/stateshape/StateToolFactory.cpp 2c8e747 
>   braindump/plugins/webshape/WebShapeFactory.cpp aec1d68 
>   braindump/plugins/webshape/WebToolFactory.cpp 9983b7d 
>   braindump/src/SectionsBoxDock.cpp 4201ab0 
>   braindump/src/View.cpp 4356654 
>   braindump/src/import/ToolDocker.cpp f5bdff1 
>   flow/plugins/dockers/stencilboxdocker/StencilBoxDocker.cpp 2be1dbb 
>   karbon/plugins/flattenpath/FlattenPathPlugin.cpp b700224 
>   karbon/plugins/refinepath/RefinePathPlugin.cpp 4698ee1 
>   karbon/plugins/roundcorners/RoundCornersPlugin.cpp 8b4041e 
>   karbon/plugins/tools/CalligraphyTool/KarbonCalligraphicShapeFactory.cpp 63ead16 
>   karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyOptionWidget.cpp fe9e19a 
>   karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyToolFactory.cpp 0342e6e 
>   karbon/plugins/tools/KarbonGradientToolFactory.cpp 8f922e4 
>   karbon/plugins/tools/KarbonPatternToolFactory.cpp dd6dad6 
>   karbon/plugins/tools/KarbonPencilToolFactory.cpp c1eb00a 
>   karbon/plugins/tools/filterEffectTool/FilterEffectEditWidget.cpp 6d3480a 
>   karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsTool.cpp e4d6eea 
>   karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsToolFactory.cpp 089fc36 
>   karbon/plugins/whirlpinch/WhirlPinchPlugin.cpp 1e4dc46 
>   karbon/ui/KarbonView.cpp 9da754e 
>   karbon/ui/dialogs/KarbonConfigureDialog.cpp b7a45b1 
>   karbon/ui/dockers/KarbonLayerDocker.cpp df569b5 
>   karbon/ui/dockers/KarbonLayerModel.cpp fff70b7 
>   karbon/ui/widgets/KarbonGradientWidget.cpp 6cf5759 
>   kexi/core/KexiStandardAction.cpp 10a9cb4 
>   kexi/core/KexiWindow.h e64f9d9 
>   kexi/core/KexiWindow.cpp f49c967 
>   kexi/core/kexi.h b6eb4a3 
>   kexi/core/kexi.cpp 4408e8b 
>   kexi/core/kexipart.cpp 7ffe8896 
>   kexi/core/kexipartinfo.h d2fb38a 
>   kexi/core/kexipartinfo.cpp a89cd38 
>   kexi/core/kexipartinfo_p.h aaa904b 
>   kexi/core/kexisharedactionhost.cpp f0b7e60 
>   kexi/core/kexitemplateloader.cpp 901994c 
>   kexi/doc/dev/CHANGELOG-Kexi-js 3ce83b1 
>   kexi/formeditor/WidgetTreeWidget.cpp 82e4b3c 
>   kexi/formeditor/connectiondialog.cpp 88aff80 
>   kexi/formeditor/editlistviewdialog.cpp f66ceaa 
>   kexi/formeditor/factories/containerfactory.cpp 97d74ac 
>   kexi/formeditor/factories/stdwidgetfactory.cpp ff4f451 
>   kexi/formeditor/form.cpp 5746780 
>   kexi/formeditor/kexiactionselectiondialog.cpp 15e59d6 
>   kexi/formeditor/libactionwidget.cpp 5c218bf 
>   kexi/formeditor/richtextdialog.cpp 80748a5 
>   kexi/formeditor/tabstopdialog.cpp 7e3b859 
>   kexi/formeditor/widgetlibrary.cpp 4850567 
>   kexi/kexidb/utils.h 0ea87b6 
>   kexi/kexidb/utils.cpp bb3f78c 
>   kexi/kexiutils/KexiAssistantPage.cpp 609a129 
>   kexi/kexiutils/debuggui.cpp d248f8f 
>   kexi/kexiutils/kmessagewidget.cpp 371e3f6 
>   kexi/kexiutils/utils.h 5d06a2d 
>   kexi/main/KexiMainWindow.cpp 3bef113 
>   kexi/main/KexiMainWindow_p.h db5c644 
>   kexi/main/KexiSearchLineEdit.cpp 3534bfe 
>   kexi/main/kexifinddialog.cpp ec9f878 
>   kexi/main/startup/KexiNewProjectAssistant.cpp 1c52d79 
>   kexi/main/startup/KexiOpenProjectAssistant.cpp 1eccd21 
>   kexi/main/startup/KexiRecentProjectsModel.cpp 663063a 
>   kexi/main/startup/KexiStartup.cpp f2e8d32 
>   kexi/main/startup/KexiStartupDialog.cpp 31678b5 
>   kexi/main/startup/KexiStartupFileDialog_win.cpp 4ebe79c 
>   kexi/main/startup/KexiWelcomeAssistant.cpp 06b242d 
>   kexi/migration/AlterSchemaWidget.cpp de4f459 
>   kexi/migration/importoptionsdlg.cpp a04e3c8 
>   kexi/migration/importtablewizard.cpp e4f9faa 
>   kexi/migration/importwizard.cpp e292a9a 
>   kexi/mobile/KexiMobileMainWindow.cpp a44cbfa 
>   kexi/mobile/KexiMobileToolbar.cpp 13c0a73 
>   kexi/plugins/forms/kexidatasourcepage.cpp 31923ba 
>   kexi/plugins/forms/kexidbfactory.cpp 8f53bf9 
>   kexi/plugins/forms/kexidbfactorybase.cpp b374169 
>   kexi/plugins/forms/kexiformmanager.cpp 9b202fc 
>   kexi/plugins/forms/kexiformpart.cpp 2a55c0a 
>   kexi/plugins/forms/widgets/kexidbimagebox.cpp e2c4890 
>   kexi/plugins/forms/widgets/kexidblineedit.cpp 9b2b98f 
>   kexi/plugins/forms/widgets/kexidbutils.cpp 7c7088e 
>   kexi/plugins/importexport/csv/kexicsvexport.cpp be09ea1 
>   kexi/plugins/importexport/csv/kexicsvexportwizard.cpp 34df802 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.cpp a1dbd64 
>   kexi/plugins/queries/kexiquerydesignersql.cpp 381ffcf 
>   kexi/plugins/queries/kexiquerydesignersqlhistory.cpp 9fab621 
>   kexi/plugins/relations/kexirelationmaindlg.h 4055f4b 
>   kexi/plugins/relations/kexirelationmaindlg.cpp 2f73edd 
>   kexi/plugins/relations/kexirelationpartimpl.cpp 3c407a6 
>   kexi/plugins/reports/kexireportdesignview.cpp 3cf1439 
>   kexi/plugins/reports/kexireportpart.cpp 6f3074e 
>   kexi/plugins/reports/kexireportview.cpp ccdf3f9 
>   kexi/plugins/shapes/relationdesign/kexirelationdesignfactory.cpp 8d142d3 
>   kexi/plugins/shapes/relationdesign/kexirelationdesigntool.cpp bb632cb 
>   kexi/plugins/shapes/relationdesign/kexirelationdesigntoolfactory.cpp 4cc87bf 
>   kexi/plugins/tables/kexitabledesignerview.cpp a801bc7 
>   kexi/plugins/tables/kexitabledesignerview_p.cpp 25f5b76 
>   kexi/plugins/tables/kexitablepart.cpp 7d9fbab 
>   kexi/tests/migration/main.cpp c512bb2 
>   kexi/tests/tableview/main.cpp cd2c6ae 
>   kexi/widget/KexiConnectionSelectorWidget.cpp e01b962 
>   kexi/widget/KexiDataSourceComboBox.cpp eb01f4a 
>   kexi/widget/KexiProjectSelectorWidget.cpp a3e7da4 
>   kexi/widget/fields/KexiFieldComboBox.cpp 1bc43e6 
>   kexi/widget/fields/KexiFieldListModelItem.cpp 0a81173 
>   kexi/widget/fields/KexiFieldListView.cpp cc5b779 
>   kexi/widget/kexidbconnectionwidget.cpp 6fa9a6e 
>   kexi/widget/kexidbdrivercombobox.cpp 2989593 
>   kexi/widget/kexiprjtypeselector.cpp e1fa54c 
>   kexi/widget/kexisectionheader.cpp b187d8b 
>   kexi/widget/navigator/KexiProjectListView.cpp 3fa561f 
>   kexi/widget/navigator/KexiProjectListViewItem.cpp 540aaee 
>   kexi/widget/navigator/KexiProjectModelItem.cpp 6f2fa9f 
>   kexi/widget/navigator/KexiProjectNavigator.cpp 9c39a1a 
>   kexi/widget/pixmapcollection.cpp b4f9dfe 
>   kexi/widget/properties/KexiPropertyPaneViewBase.cpp bb58b19 
>   kexi/widget/relations/KexiRelationsTableContainer.cpp 508b3d6 
>   kexi/widget/relations/KexiRelationsView.cpp ee39b8e 
>   kexi/widget/tableview/kexidatatable.cpp 2eecce6 
>   kexi/widget/tableview/kexitableview.cpp 75abd24 
>   kexi/widget/utils/kexicontextmenuutils.cpp 355747f 
>   kexi/widget/utils/kexirecordnavigator.cpp 02a7674 
>   krita/image/generator/kis_generator_layer.cpp 73ffbc6 
>   krita/image/kis_adjustment_layer.cc c726642 
>   krita/image/kis_base_node.cpp 904f159 
>   krita/image/kis_clone_layer.cpp 871d5d3 
>   krita/image/kis_effect_mask.h 46a5d61 
>   krita/image/kis_effect_mask.cc 20c1926 
>   krita/image/kis_external_layer_iface.h a029d2b 
>   krita/image/kis_filter_mask.cpp 0059018 
>   krita/image/kis_group_layer.cc ffb542f 
>   krita/image/kis_paint_layer.cc 1f2261e 
>   krita/image/kis_selection_mask.h 4a60ee3 
>   krita/image/kis_selection_mask.cpp 1e9aba8 
>   krita/image/kis_transparency_mask.cc 922df76 
>   krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.h 12f0335 
>   krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.cc f189346 
>   krita/plugins/extensions/bigbrother/actionseditor/kis_actions_editor.cpp da4439d 
>   krita/plugins/extensions/bigbrother/bigbrother.cc f13c7ac 
>   krita/plugins/extensions/colorrange/colorrange.cc 41e11c3 
>   krita/plugins/extensions/colorspaceconversion/colorspaceconversion.cc 3bb48a8 
>   krita/plugins/extensions/compose/kis_layer_compose_plugin.cpp e4130ad 
>   krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector.cpp f4cbb8a 
>   krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_container.cpp cb2bd23 
>   krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_settings.cpp 6c423c3 
>   krita/plugins/extensions/dockers/advancedcolorselector/kis_common_colors.cpp c6467e4 
>   krita/plugins/extensions/dockers/compositiondocker/compositiondocker_dock.cpp 36fe381 
>   krita/plugins/extensions/dockers/compositiondocker/compositionmodel.cpp d6c6496 
>   krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp 87ad14a 
>   krita/plugins/extensions/dockers/defaultdockers/wdgbirdeye.ui e10037a 
>   krita/plugins/extensions/dockers/tasksetdocker/tasksetdocker_dock.cpp 08f6ac6 
>   krita/plugins/extensions/dockers/tasksetdocker/tasksetmodel.cpp ac04220 
>   krita/plugins/extensions/dropshadow/kis_dropshadow.cc 0882397 
>   krita/plugins/extensions/dropshadow/kis_dropshadow_plugin.cc 6bfff9c 
>   krita/plugins/extensions/histogram/histogram.cc 6255b9e 
>   krita/plugins/extensions/imagesize/dlg_canvassize.cc ee3d601 
>   krita/plugins/extensions/imagesize/imagesize.cc 8a068e4 
>   krita/plugins/extensions/imagesize/multilock_button.cc 6aa5c1a 
>   krita/plugins/extensions/imagesplit/imagesplit.cpp ad10825 
>   krita/plugins/extensions/modify_selection/modify_selection.cc 3e8014b 
>   krita/plugins/extensions/rotateimage/rotateimage.cc c56791a 
>   krita/plugins/extensions/separate_channels/kis_channel_separator.cc 9acd5f3 
>   krita/plugins/extensions/separate_channels/kis_separate_channels_plugin.cc 029033d 
>   krita/plugins/extensions/shearimage/shearimage.cc 7b52ca0 
>   krita/plugins/filters/colorsfilters/colorsfilters.cpp 011e839 
>   krita/plugins/filters/embossfilter/kis_emboss_filter.cpp f486d38 
>   krita/plugins/filters/example/example.cpp e49b4c4 
>   krita/plugins/filters/imageenhancement/imageenhancement.cpp e885f01 
>   krita/plugins/filters/noisefilter/noisefilter.cpp 5f43791 
>   krita/plugins/filters/oilpaintfilter/kis_oilpaint_filter.cpp 0b67eab 
>   krita/plugins/filters/pixelizefilter/kis_pixelize_filter.cpp f6522a2 
>   krita/plugins/filters/raindropsfilter/kis_raindrops_filter.cpp 1a9c802 
>   krita/plugins/filters/randompickfilter/randompickfilter.cpp 0af9fdc 
>   krita/plugins/filters/smalltilesfilter/kis_small_tiles_filter.cpp c85f982 
>   krita/plugins/filters/sobelfilter/kis_sobel_filter.cpp 25a9c5f 
>   krita/plugins/filters/wavefilter/wavefilter.cpp c9065f5 
>   krita/plugins/generators/solid/colorgenerator.cpp 6c97e35 
>   krita/plugins/paintops/chalk/chalk_paintop_plugin.cpp 817df1d 
>   krita/plugins/paintops/colorsmudge/colorsmudge_paintop_plugin.cpp 4429965 
>   krita/plugins/paintops/curvebrush/curve_paintop_plugin.cpp 01c11f2 
>   krita/plugins/paintops/defaultpaintops/defaultpaintops_plugin.cc b87979f 
>   krita/plugins/paintops/deform/deform_paintop_plugin.cpp d8c0c25 
>   krita/plugins/paintops/experiment/experiment_paintop_plugin.cpp 1376e9a 
>   krita/plugins/paintops/filterop/filterop.cpp ad8cb7a 
>   krita/plugins/paintops/gridbrush/grid_paintop_plugin.cpp ccd5cc2 
>   krita/plugins/paintops/hairy/hairy_paintop_plugin.cpp a472caf 
>   krita/plugins/paintops/hatching/hatching_paintop_plugin.cpp 0481ead 
>   krita/plugins/paintops/libpaintop/kis_compositeop_option.cpp 8238457 
>   krita/plugins/paintops/mypaint/mypaint_paintop_plugin.cpp 3868bc3 
>   krita/plugins/paintops/sketch/sketch_paintop_plugin.cpp a8cbb2f 
>   krita/plugins/paintops/spray/spray_paintop_plugin.cpp 2fb2cc4 
>   krita/plugins/paintops/waterymixbrush/waterymix_paintop_plugin.cpp 2b8a1be 
>   krita/plugins/tools/defaulttools/kis_tool_brush.h e64b047 
>   krita/plugins/tools/defaulttools/kis_tool_colorpicker.h 84dc9b4 
>   krita/plugins/tools/defaulttools/kis_tool_ellipse.h 32a286a 
>   krita/plugins/tools/defaulttools/kis_tool_fill.h 8ec6bb1 
>   krita/plugins/tools/defaulttools/kis_tool_gradient.h 8e24d33 
>   krita/plugins/tools/defaulttools/kis_tool_line.h 0822d6b 
>   krita/plugins/tools/defaulttools/kis_tool_measure.h 7d0e92c 
>   krita/plugins/tools/defaulttools/kis_tool_move.h d70a526 
>   krita/plugins/tools/defaulttools/kis_tool_multihand.h 36800cd 
>   krita/plugins/tools/defaulttools/kis_tool_pan.h 07b9d23 
>   krita/plugins/tools/defaulttools/kis_tool_path.h 6900fb7 
>   krita/plugins/tools/defaulttools/kis_tool_rectangle.h be3d761 
>   krita/plugins/tools/selectiontools/kis_tool_select_brush.h 431742d 
>   krita/plugins/tools/selectiontools/kis_tool_select_contiguous.h 474925c 
>   krita/plugins/tools/selectiontools/kis_tool_select_elliptical.h f924c55 
>   krita/plugins/tools/selectiontools/kis_tool_select_outline.h 7163c6b 
>   krita/plugins/tools/selectiontools/kis_tool_select_path.h 11f3e0f 
>   krita/plugins/tools/selectiontools/kis_tool_select_polygonal.h e40fd8c 
>   krita/plugins/tools/selectiontools/kis_tool_select_rectangular.h 01ac51f 
>   krita/plugins/tools/selectiontools/kis_tool_select_similar.h f573bcd 
>   krita/plugins/tools/tool_crop/kis_tool_crop.h 5e2e224 
>   krita/plugins/tools/tool_crop/tool_crop.cc 279266d 
>   krita/plugins/tools/tool_dyna/kis_tool_dyna.h 825e018 
>   krita/plugins/tools/tool_dyna/tool_dyna.cpp 967c1af 
>   krita/plugins/tools/tool_grid/kis_tool_grid.h bd2f6ae 
>   krita/plugins/tools/tool_grid/tool_grid.cc 5bd0e74 
>   krita/plugins/tools/tool_perspectivegrid/kis_tool_perspectivegrid.h a998743 
>   krita/plugins/tools/tool_perspectivegrid/kis_tool_perspectivegrid.cc c4ae45e 
>   krita/plugins/tools/tool_perspectivegrid/tool_perspectivegrid.cc 31b1ac8 
>   krita/plugins/tools/tool_polygon/kis_tool_polygon.h d0b8713 
>   krita/plugins/tools/tool_polygon/tool_polygon.cc 597b136 
>   krita/plugins/tools/tool_polyline/kis_tool_polyline.h 5df8500 
>   krita/plugins/tools/tool_polyline/tool_polyline.cc 07b7a67 
>   krita/plugins/tools/tool_star/kis_tool_star.h 903cb58 
>   krita/plugins/tools/tool_star/tool_star.cc 1ec4a58 
>   krita/plugins/tools/tool_text/kis_tool_text.h ba149d3 
>   krita/plugins/tools/tool_text/tool_text.cc 2e6ae49 
>   krita/plugins/tools/tool_transform2/kis_tool_transform.h b92a7dd 
>   krita/plugins/tools/tool_transform2/tool_transform.cc 7996a7b 
>   krita/sdk/templates/filter/APPNAMELC.cc e2468a7 
>   krita/ui/dialogs/kis_dlg_preferences.cc 8cbcddf 
>   krita/ui/flake/kis_shape_layer.cc cb6248a 
>   krita/ui/kis_cursor.cc 02ec083 
>   krita/ui/kis_image_manager.cc 074e3fb 
>   krita/ui/kis_layer_manager.cc f2b659c 
>   krita/ui/kis_node_manager.cpp aa6fb28 
>   krita/ui/kis_paintop_box.cc 8841c0b 
>   krita/ui/kis_palette_manager.cpp 80df662 
>   krita/ui/kis_statusbar.cc fd5564a 
>   krita/ui/recorder/kis_node_query_path_editor.cc 05eb03e 
>   krita/ui/thememanager.cpp 62fdeb3 
>   krita/ui/tool/kis_tool_paint.cc 61be742 
>   krita/ui/widgets/kis_color_space_selector.cc 9d55e09 
>   krita/ui/widgets/kis_custom_image_widget.cc 5b7af8d 
>   krita/ui/widgets/kis_paintop_presets_chooser_popup.cpp d23ecc0 
>   krita/ui/widgets/kis_paintop_presets_popup.cpp 0311c4b 
>   krita/ui/widgets/kis_preset_chooser.cpp 7cc468f 
>   krita/ui/widgets/kis_preset_selector_strip.cpp 61d2d5f 
>   krita/ui/widgets/kis_progress_widget.cpp 167a2f0 
>   krita/ui/widgets/kis_selection_options.cc be692fb 
>   libs/flake/KoConnectionShapeFactory.cpp dcd9917 
>   libs/flake/KoPathShapeFactory.cpp e441c93 
>   libs/flake/KoShapeFactoryBase.h ab89452 
>   libs/flake/KoShapeFactoryBase.cpp 5c5ec48 
>   libs/flake/KoToolFactoryBase.h ca53c93 
>   libs/flake/KoToolFactoryBase.cpp 4ec419d 
>   libs/flake/KoToolManager_p.cpp 89bf70e 
>   libs/flake/SnapGuideConfigWidget.cpp 1bb7cd2 
>   libs/flake/tools/KoCreatePathToolFactory.cpp 9d25fa5 
>   libs/flake/tools/KoPanToolFactory.cpp 07cb5ef 
>   libs/flake/tools/KoPathTool.cpp 5129f67 
>   libs/flake/tools/KoPathToolFactory.cpp 13359b9 
>   libs/flake/tools/KoZoomToolFactory.cpp d6dcb92 
>   libs/flake/tools/KoZoomToolWidget.cpp 6196743 
>   libs/kokross/KoScriptManager.cpp 3b0fe0e 
>   libs/kokross/KoScriptingDocker.cpp e6a78a2 
>   libs/kopageapp/KoPADocumentModel.cpp 69feb88 
>   libs/kopageapp/KoPADocumentStructureDocker.cpp 7b31e54 
>   libs/kopageapp/KoPAView.cpp 6161032 
>   libs/kopageapp/dialogs/KoPAConfigureDialog.cpp b7f577c 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp 92ac030 
>   libs/koproperty/EditorView.cpp a442249 
>   libs/koproperty/Utils.cpp b2b641a 
>   libs/koproperty/editors/booledit.cpp aeee2af 
>   libs/koproperty/editors/cursoredit.cpp b7c072a 
>   libs/koproperty/test/test.cpp 33da9d3 
>   libs/koreport/items/check/KoReportCheckPlugin.cpp ba9bf3f 
>   libs/koreport/items/field/KoReportFieldPlugin.cpp 2a34880 
>   libs/koreport/items/image/KoReportImagePlugin.cpp f7d7b98 
>   libs/koreport/items/label/KoReportLabelPlugin.cpp 3a745af 
>   libs/koreport/items/text/KoReportTextPlugin.cpp 4d7762e 
>   libs/koreport/wrtembed/KoReportDesigner.cpp 78dda97 
>   libs/kundo2/kundo2stack.cpp bf63eea 
>   libs/main/KoDocument.h 0a28c7c 
>   libs/main/KoDocument.cpp d2d3938 
>   libs/main/KoDocumentInfoDlg.cpp 2532560 
>   libs/main/KoFindToolbar.cpp 0199c6a 
>   libs/main/KoGridData.cpp 239fc73 
>   libs/main/KoMainWindow.cpp c01f44d 
>   libs/main/KoOpenPane.cpp 568ce88 
>   libs/main/KoTemplateGroup.cpp 3c75fda 
>   libs/main/KoTemplateTree.cpp d278f43 
>   libs/main/KoToolDocker.cpp 0df2b64 
>   libs/main/KoUndoStackAction.cpp 201b3c1 
>   libs/main/KoVersionDialog.cpp eeb17d0 
>   libs/main/KoView.cpp 4de2298 
>   libs/widgets/KoAspectButton.cpp 883ff2b 
>   libs/widgets/KoDockWidgetTitleBar.cpp bc7e869 
>   libs/widgets/KoEditColorSetDialog.cpp e696288 
>   libs/widgets/KoResourceItemChooser.cpp 933652c 
>   libs/widgets/KoSelectionToggle.cpp 6ad6866 
>   libs/widgets/KoStrokeConfigWidget.cpp 3c5025a 
>   libs/widgets/KoZoomAction.cpp cfdd940 
>   plan/about/aboutpage.cpp 3242acb 
>   plan/kptfactory.cpp 4837d19 
>   plan/kptinsertfiledlg.cpp 1b3ea07 
>   plan/kptview.cpp c9175ae 
>   plan/kptviewlist.cpp b72c04a 
>   plan/kptviewlistdialog.cpp 72c78dc 
>   plan/libs/models/kcalendar/kdatepicker.cpp 3a36d57 
>   plan/libs/models/kptaccountsmodel.cpp 76108c2 
>   plan/libs/models/kptnodeitemmodel.cpp 5ace17a 
>   plan/libs/models/kptresourcemodel.cpp fddba1e 
>   plan/libs/models/kptschedulemodel.cpp f9c15f5 
>   plan/libs/ui/kmessagebox_copy.cpp a1f93e9 
>   plan/libs/ui/kptaccountseditor.cpp 4adb528 
>   plan/libs/ui/kptcalendareditor.cpp f3feee3 
>   plan/libs/ui/kptdependencyeditor.cpp c19a9d1 
>   plan/libs/ui/kptdocumentseditor.cpp 464951e 
>   plan/libs/ui/kptintervaledit.cpp d211979 
>   plan/libs/ui/kptperteditor.cpp 9f37b6e 
>   plan/libs/ui/kptresourceeditor.cpp 0856060 
>   plan/libs/ui/kptscheduleeditor.cpp 6d9f5a5 
>   plan/libs/ui/kpttaskeditor.cpp 6423482 
>   plan/libs/ui/kpttaskprogresspanel.cpp 5bf19aa 
>   plan/libs/ui/kptviewbase.cpp 8c82751 
>   plan/libs/ui/kptworkpackagesendpanel.cpp 22fd92b 
>   plan/libs/ui/reports/reportdesignview.cpp ce83ed0 
>   plan/libs/ui/reports/reportexportpanel.cpp 973078d 
>   plan/libs/ui/reports/reportview.cpp dea21a6 
>   plan/workpackage/application.cpp f81c5cd 
>   plan/workpackage/main.cpp a9b3f42 
>   plan/workpackage/mainwindow.cpp dafc788 
>   plan/workpackage/taskcompletiondialog.cpp 70d1e05 
>   plan/workpackage/taskworkpackageview.cpp af24826 
>   plan/workpackage/view.cpp 89b7c82 
>   plugins/artistictextshape/ArtisticTextShapeFactory.cpp 2438b20 
>   plugins/artistictextshape/ArtisticTextTool.cpp d069e46 
>   plugins/artistictextshape/ArtisticTextToolFactory.cpp c4a9918 
>   plugins/chartshape/ChartShapeFactory.cpp 750596e 
>   plugins/chartshape/ChartTool.cpp bab225a 
>   plugins/chartshape/ChartToolFactory.cpp c59692b 
>   plugins/chartshape/dialogs/TableEditorDialog.cpp 62acce9 
>   plugins/commentshape/CommentToolFactory.cpp 9198704 
>   plugins/defaultTools/connectionTool/ConnectionTool.cpp d95a34f 
>   plugins/defaultTools/connectionTool/ConnectionToolFactory.cpp 6a04221 
>   plugins/defaultTools/defaulttool/DefaultTool.cpp 4a0b1af 
>   plugins/defaultTools/defaulttool/DefaultToolFactory.cpp a0e97cd 
>   plugins/defaultTools/guidestool/GuidesToolOptionWidget.cpp d2e5f72 
>   plugins/defaultTools/guidestool/InsertGuidesToolOptionWidget.cpp 21ab34b 
>   plugins/dockers/shapecollection/ShapeCollectionDocker.cpp f863b3a 
>   plugins/dockers/strokedocker/StrokeDocker.cpp 335562a 
>   plugins/dockers/styledocker/StyleButtonBox.cpp 17a145d 
>   plugins/formulashape/KoFormulaShapeFactory.cpp 7ce11fd 
>   plugins/formulashape/KoFormulaTool.h 6e9be42 
>   plugins/formulashape/KoFormulaTool.cpp 733d6f2 
>   plugins/formulashape/KoFormulaToolFactory.cpp d839b87 
>   plugins/musicshape/MusicShapeFactory.cpp dcf29f5 
>   plugins/musicshape/MusicTool.cpp fc1ccf0 
>   plugins/musicshape/MusicToolFactory.cpp 39d176b 
>   plugins/musicshape/SimpleEntryTool.cpp 529cf9c 
>   plugins/musicshape/SimpleEntryToolFactory.cpp a68e114 
>   plugins/musicshape/actions/AccidentalAction.cpp 0691068 
>   plugins/musicshape/actions/DotsAction.cpp 7b1bca0 
>   plugins/musicshape/actions/EraserAction.cpp b076f09 
>   plugins/musicshape/actions/NoteEntryAction.cpp 70484c8 
>   plugins/musicshape/actions/SelectionAction.cpp 2562f1c 
>   plugins/musicshape/actions/SetClefAction.cpp 34c5204 
>   plugins/musicshape/actions/TiedNoteAction.cpp 9c06fdd 
>   plugins/musicshape/dialogs/PartsWidget.cpp 4128dce 
>   plugins/pathshapes/ellipse/EllipseShapeFactory.cpp 1ad5c93 
>   plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp d820c43 
>   plugins/pathshapes/rectangle/RectangleShapeFactory.cpp c313fbc 
>   plugins/pathshapes/spiral/SpiralShapeFactory.cpp b9f902f 
>   plugins/pathshapes/star/StarShapeFactory.cpp e6a9c6d 
>   plugins/pictureshape/PictureShapeFactory.cpp 84b470d 
>   plugins/pictureshape/PictureTool.cpp b46f05a 
>   plugins/pictureshape/PictureToolFactory.cpp cc47406 
>   plugins/reporting/barcode/KoReportBarcodePlugin.cpp 2f269ab 
>   plugins/reporting/chart/KoReportChartPlugin.cpp 371cb97 
>   plugins/reporting/maps/KoReportMapsPlugin.cpp 932c81d 
>   plugins/reporting/web/KoReportWebPlugin.cpp a49d7ac 
>   plugins/staging/templateshape/TemplateTool.cpp 6373aa2 
>   plugins/textediting/thesaurus/Thesaurus.cpp eeacbba 
>   plugins/textshape/TextShapeFactory.cpp a798ee2 
>   plugins/textshape/TextTool.cpp 4078e72 
>   plugins/textshape/dialogs/CharacterHighlighting.cpp 8807cfd 
>   plugins/textshape/dialogs/LanguageTab.cpp a50d611 
>   plugins/textshape/dialogs/QuickTableButton.cpp 470db88 
>   plugins/textshape/dialogs/SimpleTableWidget.cpp 9254d59 
>   plugins/textshape/dialogs/StylesComboPreview.cpp 99ba965 
>   plugins/textshape/dialogs/StylesDelegate.cpp 2934fa9 
>   plugins/textshape/dialogs/StylesModel.h 53c0225 
>   plugins/textshape/dialogs/StylesModel.cpp 3b03f1b 
>   plugins/textshape/tests/TestChangeTrackedDelete.cpp 7cb6b15 
>   plugins/variables/FixedDateFormat.cpp f865821 
>   plugins/vectorshape/VectorShapeFactory.cpp 07e02ae 
>   plugins/vectorshape/VectorTool.cpp 79742fd 
>   plugins/vectorshape/VectorToolFactory.cpp 04212c6 
>   plugins/videoshape/VideoShape.cpp 2c76d30 
>   plugins/videoshape/VideoShapeFactory.cpp 7235eaf 
>   sheets/Global.h b5421b4 
>   sheets/MapModel.cpp 4aa9fbd 
>   sheets/Style.cpp e86ebd3 
>   sheets/dialogs/ConsolidateDialog.cpp b4869e2 
>   sheets/dialogs/DocumentSettingsDialog.cpp 6b76bff 
>   sheets/dialogs/FormulaDialog.cpp d445694 
>   sheets/dialogs/LayoutDialog.cpp 7372d38 
>   sheets/dialogs/LinkDialog.cpp 4ce4636 
>   sheets/dialogs/SortDialog.cpp 4b0fd21 
>   sheets/part/CellToolFactory.h 062c9cc 
>   sheets/part/CellToolFactory.cpp fd3df68 
>   sheets/part/ToolRegistry.cpp d08ff7e 
>   sheets/part/View.cpp 5c11f98 
>   sheets/part/dialogs/PreferenceDialog.cpp 2bf53c4 
>   sheets/part/dialogs/SheetSelectPage.cpp 69de4a3 
>   sheets/plugins/calendar/CalendarTool.cpp 1812e8f 
>   sheets/plugins/calendar/CalendarToolWidget.cpp a7c7814 
>   sheets/shape/SheetsEditor.cpp 5c1ba6b 
>   sheets/shape/TableShapeFactory.cpp 98102a6 
>   sheets/shape/TableTool.cpp 8c6d277 
>   sheets/shape/TableToolFactory.cpp 5eb228c 
>   sheets/ui/CellToolBase.cpp 33f2d29 
>   sheets/ui/CellToolBase_p.cpp 0cba586 
>   sheets/ui/CellToolOptionWidget.cpp 4a1d068 
>   sheets/ui/MapViewModel.cpp 2c2c669 
>   sheets/ui/RegionSelector.cpp 028f234 
>   stage/part/KPrCustomSlideShowsModel.cpp 9014886 
>   stage/part/KPrPresentationBlackStrategy.cpp d64e9c7 
>   stage/part/KPrPresentationDrawStrategy.cpp fa15b3c 
>   stage/part/KPrPresenterViewInterface.cpp e6aafb3 
>   stage/part/KPrPresenterViewToolWidget.cpp c5f294a 
>   stage/part/KPrPresenterViewWidget.cpp 65fd5be 
>   stage/part/KPrSlidesSorterDocumentModel.cpp 74e7e7b 
>   stage/part/KPrView.cpp 1606dfa 
>   stage/part/KPrViewModeSlidesSorter.cpp d7478ba 
>   stage/part/pagelayout/KPrPageLayout.cpp e7bd8be 
>   stage/part/tools/animationtool/KPrAnimationToolFactory.cpp d504930 
>   stage/part/ui/KPrPresentationToolWidget.cpp 5adf7f6 
>   words/part/KWView.cpp 53f7da5 
>   words/part/dockers/KWRdfDocker.cpp 0a44e53 
>   words/part/pagetool/KWPageToolFactory.cpp c0680ab 
> 
> Diff: http://git.reviewboard.kde.org/r/104810/diff/
> 
> 
> Testing
> -------
> 
> So far all programs look unchanged, from minimal using :)
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120524/640790f2/attachment.htm>

More information about the calligra-devel mailing list