Review Request: Fix wrong function type description for 'Date'

Boudewijn Rempt boud at valdyas.org
Thu May 24 09:00:02 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104954/#review14111
-----------------------------------------------------------

Ship it!


Ship It!

- Boudewijn Rempt


On May 15, 2012, 8:06 a.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104954/
> -----------------------------------------------------------
> 
> (Updated May 15, 2012, 8:06 a.m.)
> 
> 
> Review request for Calligra, Marijn Kruisselbrink and Sebastian Sauer.
> 
> 
> Description
> -------
> 
> FunctionDescription.cpp has "Boolean", "Int", "String", "Any", everything else is treated as Float -> that is wrong.
> 
> 
> Without the patch in 2.4 the Help for e.g. TODAY says:
> 
> The TODAY() function returns the current date.
> Return type: A floating point value (like 1.3, 0.343, 253 )
> 
> With patch:
> Return type: A string representing a date (like "2/22/2012")
> 
> There are still some unsupported Types, which are treated as Float like
> Reference, String/Numeric, Array, Range, Number
> See http://bugsfiles.kde.org/attachment.cgi?id=68157
> 
> 
> This addresses bug 290631.
>     http://bugs.kde.org/show_bug.cgi?id=290631
> 
> 
> Diffs
> -----
> 
>   sheets/FunctionDescription.h 4159c3f 
>   sheets/FunctionDescription.cpp 76d9ef7 
> 
> Diff: http://git.reviewboard.kde.org/r/104954/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120524/8f60a012/attachment.htm>


More information about the calligra-devel mailing list