Important must read: Splitting UI out of KoDocument

[Dag]

Onsdag den 23. maj 2012 09:23:20 C. Boemann skrev:
> On Wednesday 23 May 2012 06:44:11 Marijn Kruisselbrink wrote:
> > On Tuesday, May 22, 2012 08:50:10 PM C. Boemann wrote:
> > > On Tuesday 22 May 2012 20:45:15 Marijn Kruisselbrink wrote:
> > > > On Monday, May 21, 2012 11:17:32 PM C. Boemann wrote:
> > > > > Such a big branch has a tendency to bit rot quickly so please do
> > > > > your
> > > > > checking and reviewing quickly so we can merge within a week or so.
> > > > > If we don't hear from you we will assume you have tested and found
> > > > > no problems.
> > > > > 
> > > > > It's unlikely that there will be no problems, so I urge you to
> > > > > check.
> > > > > We will be at assistance and even do most fixes, but some things
> > > > > probably requires your inside knowledge of how your app works.
> > > > 
> > > > Haven't done any deep testing yet, but I noticed about 10 or so
> > > > "FIXME"
> > > > comments and commented out code being introduced in sheets. I assume
> > > > you're planning on fixing those known regressions before merging?
> > > > (things like saving of active sheet/cell, part of the INFO() function,
> > > > etc)
> > > 
> > > Well not fixing on my own, or i would have doneit already. So at the
> > > very
> > > least i was hoping some kind of hint from you so i can do the right
> > > thing.
> > > 
> > > I'll take a second look on my own, but feel free to reply with some
> > > suggestions if you have some
> > 
> > Well, I haven't quite studied what the effects of the KoDocument/KoPart
> > split are; so if you have some hints on how to get to a view from a
> > KoDocument instance after the refactor, the rest of at least the part of
> > the code saving view settings should be trivial (is Sheets the only
> > application that stores some of the view state in files?)
> > 
> > Marijn
> 
> Mostly what Boud said. My suggestion/idea is to do the settings saving in
> view or split it between kodocment and koview. kopart is involved in saving
> so it can take care of what to save where.
Same for plan. The problem, afaics, is that the KoStore is not available in 
KoPart, only in KoDocument.
I can solve this by emitting a signal from my implementation of 
completeSaving(KoStore*) which I connect to my part (or view) to do the 
saving.
Maybe a bit messy, but it saves refactoring the KoDocument saving methods.
-- 
Mvh.
Dag Andersen