Important must read: Splitting UI out of KoDocument

Thorsten Zachmann t.zachmann at zagge.de
Wed May 23 04:53:50 BST 2012


On Tuesday 22 May 2012 13:35:42 Boudewijn Rempt wrote:
> On Tuesday 22 May 2012 May, Thorsten Zachmann wrote:
> > Hello,
> > 
> > On Monday 21 May 2012 23:17:32 C. Boemann wrote:
> > > Such a big branch has a tendency to bit rot quickly so please do your
> > > checking and reviewing quickly so we can merge within a week or so. If
> > > we
> > > don't hear from you we will assume you have tested and found no
> > > problems.
> > > 
> > > It's unlikely that there will be no problems, so I urge you to check. We
> > > will be at assistance and even do most fixes, but some things probably
> > > requires your inside knowledge of how your app works.
> > 
> > I did some testing. Nothing deep yet. I noticed the following:
> > 
> > The documents docker used in flow and stage is empty in your branch.
> 
> That's probably because the partChanged signal is no longer used; we were
> not sure how to proceed there. There are some comments in the code about
> that...

I fixed it by removing the commented out code and using the setCanvas correctly 
so that it is called also when opening the first document.

Thorsten



More information about the calligra-devel mailing list