Review Request: Delayed Search: Give the user a chance to enter the whole word before begining search

Arjen Hiemstra djfreestyler at gmail.com
Mon May 21 18:47:03 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104996/#review14022
-----------------------------------------------------------

Ship it!


Seems to be fine now.

- Arjen Hiemstra


On May 20, 2012, 2:08 a.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104996/
> -----------------------------------------------------------
> 
> (Updated May 20, 2012, 2:08 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> When we try to search for a text that is most common in a large document the ui used to hang when the first letter was entered in the search box i.e. hung until the search for the first letter in the whole document is over.
> 
> Particular scenario that I have in mind: 
> 
> 1) Open the ODF 1.2 spec document in Words
> 2) Try searching for the word "the" in the document
> 3) As soon as the letter 't' is entered in the search field the user has to wait for the search to complete before he can see the other two letters "he" appear.
> 
> As a solution to the above scenario, this patch introduces a delay of 1s after the last key has been keyed before begining the search.
> 
> 
> Diffs
> -----
> 
>   libs/main/KoFindToolbar.h 9c44694 
>   libs/main/KoFindToolbar.cpp a1b8773 
> 
> Diff: http://git.reviewboard.kde.org/r/104996/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gopalakrishna Bhat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120521/74ab0193/attachment.htm>


More information about the calligra-devel mailing list