Review Request: Delayed Search: Give the user a chance to enter the whole word before begining search

[Gopalakrishna Bhat]

> On May 19, 2012, 7:09 p.m., Arjen Hiemstra wrote:
> > libs/main/KoFindToolbar.cpp, lines 273-274
> > <http://git.reviewboard.kde.org/r/104996/diff/1/?file=65014#file65014line273>
> >
> >     Since you're using a single shot timer anyway, there is no need to call stop().

There might be a scenario where the find() is called explicitly in the code rather that through the timeout of the timer. For example when the search options are changed then find() is called, if a timer is running when this happens this leads to two calls to find() which is unnecessary.


- Gopalakrishna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104996/#review13985
-----------------------------------------------------------


On May 20, 2012, 2:08 a.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104996/
> -----------------------------------------------------------
> 
> (Updated May 20, 2012, 2:08 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> When we try to search for a text that is most common in a large document the ui used to hang when the first letter was entered in the search box i.e. hung until the search for the first letter in the whole document is over.
> 
> Particular scenario that I have in mind: 
> 
> 1) Open the ODF 1.2 spec document in Words
> 2) Try searching for the word "the" in the document
> 3) As soon as the letter 't' is entered in the search field the user has to wait for the search to complete before he can see the other two letters "he" appear.
> 
> As a solution to the above scenario, this patch introduces a delay of 1s after the last key has been keyed before begining the search.
> 
> 
> Diffs
> -----
> 
>   libs/main/KoFindToolbar.h 9c44694 
>   libs/main/KoFindToolbar.cpp a1b8773 
> 
> Diff: http://git.reviewboard.kde.org/r/104996/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gopalakrishna Bhat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120520/85d9688c/attachment.htm>