Review Request: Cleanup KoDocument

Boudewijn Rempt boud at valdyas.org
Sat May 19 10:25:33 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104992/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

This patch combines several git commits and together cleans up the KoDocument interface, preparatory to removing the gui dependencies from KoDocument.

Summary:

* remove KoUnavail
* move wantExportConfirmation to a configuration setting
* move the static service handling to the KoServiceProvider class
* remove KoDocumentOdf::saveChildrenOdf (which was not not used)
* remove KoDocument::saveChilrden (was called in sheets and kounavail, but didn't do anything in sheets)
* remove all traces of widget embedding and single view mode


Diffs
-----

  CMakeLists.txt ea68694 
  flow/part/FlowDocument.h f4a580d 
  flow/part/FlowDocument.cpp cf016a3 
  flow/part/FlowFactory.cpp 15431c6 
  interfaces/koChart.h 57be5c1 
  interfaces/koChart.cc d07dcde 
  karbon/ui/KarbonFactory.cpp 5b21f2e 
  karbon/ui/KarbonPart.h aa28784 
  karbon/ui/KarbonPart.cpp e75a0ef 
  kounavail/CMakeLists.txt 8c71437 
  kounavail/Messages.sh 9b90c78 
  kounavail/README 426cf0b 
  kounavail/kounavail.cc 0cb08a3 
  kounavail/kounavail.desktop 70f140d 
  kounavail/kounavail.h 5bb4004 
  kounavail/test-kounavail.kwd a072ffb 
  kounavail/test-kounavail2.kwd 1bee4f0 
  krita/data/kritarc 7235373 
  krita/ui/kis_doc2.h ef0413b 
  krita/ui/kis_doc2.cc 01752c1 
  krita/ui/kis_factory2.cc 83c2bec 
  krita/ui/kis_selection_manager.cc f9cb00c 
  libs/kopageapp/KoPADocument.h 91457a8 
  libs/kopageapp/KoPADocument.cpp eedc136 
  libs/kopageapp/KoPAView.cpp 4d13dfa 
  libs/kopageapp/tests/PAMock.h bad1951 
  libs/main/CMakeLists.txt c6932fd 
  libs/main/KoApplication.cpp a7352cf 
  libs/main/KoDocument.h 5daa007 
  libs/main/KoDocument.cpp 03086b3 
  libs/main/KoMainWindow.cpp 8775981 
  libs/main/KoServiceProvider.h PRE-CREATION 
  libs/main/KoServiceProvider.cpp PRE-CREATION 
  libs/main/KoVersionDialog.cpp eeb17d0 
  libs/main/KoView.cpp a3f75d0 
  libs/odf/KoOdfDocument.h 51b0c2c 
  libs/odf/KoOdfDocument.cpp f08d254 
  plan/kptfactory.cpp 4837d19 
  plan/kptpart.h 4edba32 
  plan/kptpart.cpp 56a2847 
  plan/kptview.cpp c9175ae 
  plan/libs/ui/kptperteditor.cpp 9f37b6e 
  plan/plugins/scripting/Module.cpp f44b071 
  plugins/formulashape/FormulaDocument.h 7fb21a0 
  plugins/formulashape/FormulaDocument.cpp 39bf132 
  sheets/DocBase.h 2edfca3 
  sheets/DocBase.cpp aaf57d2 
  sheets/Map.h da71304 
  sheets/Map.cpp 72245b4 
  sheets/Sheet.h 250f944 
  sheets/Sheet.cpp 09ff5b8 
  sheets/part/Doc.h 3b08cee 
  sheets/part/Doc.cpp e80fad2 
  sheets/part/Factory.cpp fb612da 
  sheets/plugins/scripting/ScriptingModule.cpp d0d8535 
  stage/part/KPrDocument.h d32ad26 
  stage/part/KPrDocument.cpp 3cb0858 
  stage/part/KPrFactory.cpp 45086d1 
  stage/part/tests/PAMock.h eac4c88 
  words/part/KWDocument.h eb09e16 
  words/part/KWDocument.cpp 0ab9b42 
  words/part/KWFactory.cpp cc369f5 

Diff: http://git.reviewboard.kde.org/r/104992/diff/


Testing
-------


Thanks,

Boudewijn Rempt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120519/7f6c312e/attachment.htm>


More information about the calligra-devel mailing list