Review Request: readd applixword import filter to build

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104943/#review13813
-----------------------------------------------------------

Ship it!


Ship It!

- Boudewijn Rempt


On May 14, 2012, 2:59 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104943/
> -----------------------------------------------------------
> 
> (Updated May 14, 2012, 2:59 p.m.)
> 
> 
> Review request for Calligra and Boudewijn Rempt.
> 
> 
> Description
> -------
> 
> The Applix Word import filter was both in the initial list sent by Boud of things to remove (and noone objected).
> And it was also dealt with in the big cleanup commit 4254f88a2a816aa81e2d68e73348354814363960 . But only by having the "add_subdirectory( applixword )" removed, not the subdir filters/words/applixword, that is still present.
> 
> And so I found out (while looking at the mimetype handling in general) that the assumption that this filter has not yet been ported is wrong:
> David Faure had ported it "to output ODF rather than old-kword format" over a year ago, see 
> https://projects.kde.org/projects/calligra/repository/revisions/22eb9828bf9f3a142928d157930aeea92d50df68
> 
> So this patch reverts the removal of the Applix Word import filter from the build and adds it again.
> And without the old "if(NOT WIN32 AND NOT QT_MAC_USE_COCOA AND QT3SUPPORT)" condition as I could not find a reason to have these conditions.
> 
> 
> Diffs
> -----
> 
>   filters/words/CMakeLists.txt 4cda84c 
>   filters/words/applixword/CMakeLists.txt 289e97e 
> 
> Diff: http://git.reviewboard.kde.org/r/104943/diff/
> 
> 
> Testing
> -------
> 
> Loaded a few .aw files found on the interwebs, looked more or less alright imported in Words.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120514/81bf30cf/attachment.htm>