Review Request: Change Stage and Flow to have infinite type canvas

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104928/#review13799
-----------------------------------------------------------


Some observations I made when testing the patch:

o When moving a object out of the screen, the canvas size is not updated no scrollbar added. 
  The user first needs to zoom or go to a different page so that the correct scrollbar is shown.
o When you change between a slide that has all content on the page and a slide where also some 
  content is also left of the slide. Then the visible area jumps to the left and it does not show
  the full screen any longer.



libs/kopageapp/KoPACanvas.cpp
<http://git.reviewboard.kde.org/r/104928/#comment10945>

    Please remove the comments as they are no longer needed.



stage/part/KPrViewModeNotes.cpp
<http://git.reviewboard.kde.org/r/104928/#comment10947>

    Theoretically it is possible to call updateActivePage with a KPrMasterPage and then the dynamic_cast would catch it. Please revert.



stage/part/KPrViewModeNotes.cpp
<http://git.reviewboard.kde.org/r/104928/#comment10948>

    Maybe add a
    
    Q_ASSERT(dynamic_cast<KPrPage *>(m_view->activePage()));
    
    to catch that the assumption is correct.
    


- Thorsten Zachmann


On May 13, 2012, 1:31 a.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104928/
> -----------------------------------------------------------
> 
> (Updated May 13, 2012, 1:31 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> KoPageApp applications Stage and Flow used to have extra space reserved around the page/slide so objects could be put there. However that made it really hard for the user to work with.
> 
> This patch changes that so there si no space around the page/slide. But.. instead you can drag objects outside the page/slide without any limit at all
> 
> 
> Diffs
> -----
> 
>   libs/kopageapp/KoPACanvas.cpp 4a4748c 
>   libs/kopageapp/KoPAView.h 01fbdf1 
>   libs/kopageapp/KoPAView.cpp 4d13dfa 
>   libs/kopageapp/KoPAViewMode.cpp 6981382 
>   libs/widgets/KoZoomController.h 4f4c6a2 
>   libs/widgets/KoZoomController.cpp e10c5b4 
>   stage/part/KPrViewModeNotes.h b707770 
>   stage/part/KPrViewModeNotes.cpp c951ade 
> 
> Diff: http://git.reviewboard.kde.org/r/104928/diff/
> 
> 
> Testing
> -------
> 
> I've tested zooming in and out in Stage normal, notes, and sorter viewmodes, and in Flow.
> 
> I've tested that running presentations still work, however I've not tested presenterview.
> 
> I've tested moving shapes outside the page/slide in both Stage and Flow.
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120514/5fd20f37/attachment.htm>