Review Request: Support for path-stretchpoint-x and path-stretchpoint-y

Thorsten Zachmann t.zachmann at zagge.de
Mon May 14 05:12:28 BST 2012



> On May 13, 2012, 7:36 p.m., Inge Wallin wrote:
> > I have a feeling that this is a case of the perfect being the enemy of the good.  I think we should ship this patch and then open new bugs for the issues that you found, Zagge.

There is no hurry to rush anything in. We have enough time to fix it properly and then commit. Only by doing it that way we always have a releasable master and that is what we want.


- Thorsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104804/#review13788
-----------------------------------------------------------


On May 8, 2012, 11:20 a.m., Elvis Stansvik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104804/
> -----------------------------------------------------------
> 
> (Updated May 8, 2012, 11:20 a.m.)
> 
> 
> Review request for Calligra, Matus Hanzes, Thorsten Zachmann, and C. Boemann.
> 
> 
> Description
> -------
> 
> This patch adds support for path-stretchpoint-x and path-stretchpoint-y to the enhanced path shape. All credit for the patch goes to Matus. I simply found it at [1] where it seems to have been forgotten (filed against KOffice by mistake?).
> 
> [1] https://svn.reviewboard.kde.org/r/5978
> 
> 
> This addresses bug 258267.
>     http://bugs.kde.org/show_bug.cgi?id=258267
> 
> 
> Diffs
> -----
> 
>   plugins/pathshapes/enhancedpath/EnhancedPathShape.h 1919bb1 
>   plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp dc29c3a 
> 
> Diff: http://git.reviewboard.kde.org/r/104804/diff/
> 
> 
> Testing
> -------
> 
> I tested it with the document in bug 258267.
> 
> 
> Thanks,
> 
> Elvis Stansvik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120514/56fd92dc/attachment.htm>


More information about the calligra-devel mailing list