Review Request: Load and save contour-polygon, and wrapping around it in Words

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104873/#review13764
-----------------------------------------------------------



libs/flake/KoPathShape.cpp
<http://git.reviewboard.kde.org/r/104873/#comment10931>

    Seems you have not read this I have written in the overview part. Sorry for not putting it here. So now at the right place.
    
    The odf that the draw:contour saves is invalid. The draw:points contains double values but only int is allowed. I guess you can multiply the values by 1000 and also store a the bigger viewBox to reflect that change. Another idea whould be to drop saving of contour-polygon completely and only support saving of contour-path.
    
    


- Thorsten Zachmann


On May 13, 2012, 2:13 a.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104873/
> -----------------------------------------------------------
> 
> (Updated May 13, 2012, 2:13 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Load and save the contour-polygon and contour-path elements.
> They are stored as KoClipPath in the engine. Previously the engine only
> had support for loading and saving KoClipPath in svg
> 
> Load and save the style frame style attributes that turn contoured text run around
> (wrapping) on and off. wrap-contour and wrap-contour-mode
> 
> Use this new technology to do tight run around (simple change only requesting what we already had)
> 
> This commit also adds a method to pictureshape to create a tightfitting outline path of the image.
> It's tested and works, but is not used yet to create a KoClipPath out of it.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoPathShape.h d6e7cf1 
>   libs/flake/KoPathShape.cpp fc59f87 
>   libs/flake/KoShape.h 3b2ee21 
>   libs/flake/KoShape.cpp 40c2be2 
>   libs/flake/KoShape_p.h a8ef367 
>   libs/textlayout/KoTextLayoutObstruction.cpp 9711578 
>   plugins/pictureshape/PictureShape.h 54cc813 
>   plugins/pictureshape/PictureShape.cpp e4f58fe 
> 
> Diff: http://git.reviewboard.kde.org/r/104873/diff/
> 
> 
> Testing
> -------
> 
> I've created such contour clipping in LO
> 
> loaded and seen it work in Words, and saved it back to LO where it works (though we need to work around a bug in LO, workaround is there but not enabled in this diff)
> 
> For the unused method in the pictre shape I had hardwired it during development. I will put up a new review when I actually use the method so you may ignore it for now.
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120513/883d5591/attachment.htm>