Review Request: Fixes: remove/update unused/out-dated mimetypes "application/x-words" and "application/x-flow"

Friedrich W. H. Kossebau kossebau at kde.org
Fri May 11 01:54:47 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104910/
-----------------------------------------------------------

(Updated May 11, 2012, 12:54 a.m.)


Review request for Calligra.


Changes
-------

Removed unwanted change of CFBundleSignature from KWRD to CWRD


Description
-------

Seems there are some artifacts left-over from the BIG RENAME, i.e. the mimetypes "application/x-words" and "application/x-flow".

This patch fixes this by either changing to the new real native format of Words and Flow or removing the mimetype.
"KWDocument::extraNativeMimeTypes(...)" is removed because no longer needed. But left the method in the base class virtual for now.

Additionally it removes the files words/part/KWDLoader.* completely as they are not updated/used/compiled.

Occurences in generic_wrapper, xsltfilter and libexport are not touched, as they seem outdated anyway and I am posting another review request which removes them. 
The occurence of x-flow in flowimageexport is also not touched, because it is currently not compiled, but I am trying to port it right now.


Diffs (updated)
-----

  active/calligraactive.desktop cced14d 
  libs/flake/KoShapePaintingContext.cpp 4fd7fca 
  libs/main/DESIGN 36ccc9b 
  libs/main/KoFilterManager_p.cpp 645c18d 
  libs/main/Mainpage.dox c1da98e 
  libs/main/kodocinfopropspage.desktop 8cbf874 
  libs/main/tests/filterchain_test.cpp c7f6fd1 
  servicetypes/calligrapart.desktop a64d512 
  tools/quickprint/flow_konqi.desktop 7cfd251 
  tools/quickprint/words_konqi.desktop eb99e19 
  tools/thumbnail/calligrathumbnail.desktop e41e52c 
  words/part/Info.plist.template 17259d4 
  words/part/KWDLoader.h dfab5f0 
  words/part/KWDLoader.cpp 5f79418 
  words/part/KWDocument.h f2d812a 
  words/part/KWDocument.cpp 65d027c 

Diff: http://git.reviewboard.kde.org/r/104910/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120511/703ec195/attachment.htm>


More information about the calligra-devel mailing list