Review Request: Fix the autosave recovery system
Boudewijn Rempt
boud at valdyas.org
Thu May 10 11:24:39 BST 2012
> On May 10, 2012, 10:20 a.m., Franz Fellner wrote:
> > Recovery for new and unsaved documents works now, for saved ones does not - pressing "save" after recovery pops up the save-file-dialog, which is unexpected, because I just opened an existing file (recovery of saved documents does not use the new recovery dialog, it just recognizes an autosave file for a document the user opens). Furthermore, if the user does not save the recovered file under the original filename, the autosave-file will not be deleted, leading to another recovery request (side-effect from the the first problem, I think).
Thanks for testing. I thought I had only touched recovery for unsaved files, and I'll check again.
- Boudewijn
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104892/#review13659
-----------------------------------------------------------
On May 10, 2012, 8:06 a.m., Boudewijn Rempt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104892/
> -----------------------------------------------------------
>
> (Updated May 10, 2012, 8:06 a.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> 1) X-KDE-NativeExtension can be empy, in that case take mime->mainExtension.
>
> Otherwise our autosave files are called .autosave, and that's not something
> the filter's mime detection can handle
>
> 2) don't overwrite autosave files when running multiple unnamed modified
> documents
>
> 3) tag the autosave files with the pid and use dbus to check which processes
> that have autosave files are still active; don't offer to recover those.
>
> 4) show the autosave files in a nice dialog with the ora/odf thumbnail
> as a preview, and offer to recover them all.
>
>
> This addresses bug 299611.
> http://bugs.kde.org/show_bug.cgi?id=299611
>
>
> Diffs
> -----
>
> libs/main/CMakeLists.txt ea408b7
> libs/main/KoApplication.cpp 12ddec3
> libs/main/KoAutoSaveRecoveryDialog.h PRE-CREATION
> libs/main/KoAutoSaveRecoveryDialog.cpp PRE-CREATION
> libs/main/KoDocument.h 0a28c7c
> libs/main/KoDocument.cpp d2d3938
> libs/main/KoMainWindow.cpp c01f44d
>
> Diff: http://git.reviewboard.kde.org/r/104892/diff/
>
>
> Testing
> -------
>
> went manually through all possible scenarios
>
>
> Screenshots
> -----------
>
> autosavefile recovery dialog
> http://git.reviewboard.kde.org/r/104892/s/561/
>
>
> Thanks,
>
> Boudewijn Rempt
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120510/772b83ad/attachment.htm>
More information about the calligra-devel
mailing list