Review Request: Fix the autosave recovery system

Boudewijn Rempt boud at valdyas.org
Thu May 10 09:06:25 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104892/
-----------------------------------------------------------

(Updated May 10, 2012, 8:06 a.m.)


Review request for Calligra.


Changes
-------

This updated diff fixes the issues noted by boemann and by Franz.


Description
-------

1) X-KDE-NativeExtension can be empy, in that case take mime->mainExtension.
    
    Otherwise our autosave files are called .autosave, and that's not something
    the filter's mime detection can handle
    
2) don't overwrite autosave files when running multiple unnamed modified
    documents
    
3) tag the autosave files with the pid and use dbus to check which processes
    that have autosave files are still active; don't offer to recover those.
    
4) show the autosave files in a nice dialog with the ora/odf thumbnail
    as a preview, and offer to recover them all.


This addresses bug 299611.
    http://bugs.kde.org/show_bug.cgi?id=299611


Diffs (updated)
-----

  libs/main/CMakeLists.txt ea408b7 
  libs/main/KoApplication.cpp 12ddec3 
  libs/main/KoAutoSaveRecoveryDialog.h PRE-CREATION 
  libs/main/KoAutoSaveRecoveryDialog.cpp PRE-CREATION 
  libs/main/KoDocument.h 0a28c7c 
  libs/main/KoDocument.cpp d2d3938 
  libs/main/KoMainWindow.cpp c01f44d 

Diff: http://git.reviewboard.kde.org/r/104892/diff/


Testing
-------

went manually through all possible scenarios


Screenshots
-----------

autosavefile recovery dialog
  http://git.reviewboard.kde.org/r/104892/s/561/


Thanks,

Boudewijn Rempt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120510/477d7367/attachment.htm>


More information about the calligra-devel mailing list