Review Request: Fixes: KoLineStyleSelector::paintEvent(...) not setting the pen color for the line to the text color

Thorsten Zachmann t.zachmann at zagge.de
Thu May 10 04:14:12 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104903/#review13635
-----------------------------------------------------------

Ship it!


Ship It!

- Thorsten Zachmann


On May 10, 2012, 2:25 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104903/
> -----------------------------------------------------------
> 
> (Updated May 10, 2012, 2:25 a.m.)
> 
> 
> Review request for Calligra and Thorsten Zachmann.
> 
> 
> Description
> -------
> 
> KoMarkerItemDelegate, KoMarkerSelector and KoLineStyleItemDelegate do it, setting the pen for drawing the line(s) to the color of the text.
> But this was forgotten for KoLineStyleSelector, which can be seen with dark UI color schemes.
> 
> Attached patch fixes that, by doing the same as is done in the KoLineStyleItemDelegate.
> 
> 
> Diffs
> -----
> 
>   libs/widgets/KoLineStyleSelector.cpp f29d143 
> 
> Diff: http://git.reviewboard.kde.org/r/104903/diff/
> 
> 
> Testing
> -------
> 
> Used the linestyle selector
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120510/8aeef79a/attachment.htm>


More information about the calligra-devel mailing list