Review Request: Move plans odt export into libs/koreport.

Jarosław Staniek staniek at kde.org
Wed May 9 21:43:38 BST 2012 


> On May 7, 2012, 8:50 p.m., Jarosław Staniek wrote:
> > Dag, good work, we're closer to the final. Here's my proposal for naming. This is huge change I know but you can rename the classes using KDevelop or Creator quite easily.
> > 
> > General concept: Calligra libs use static polymorphism for naming so let's keep common prefix when possible.
> > This is Frame-based ODT renderer, so the prefix can be KoOdtFrameReport.
> > I propose to put this renderer's files to libs/koreport/renderer/odtframe/
> > 
> > Below are the exact proposed renames:
> > 
> >  libs/koreport/renderer/KoReportODTRenderer2.h
> >  libs/koreport/renderer/KoReportODTRenderer2.cpp
> > 
> > KoOdtFrameReportRenderer
> > 
> >  libs/koreport/renderer/odt/KoSimpleOdtCheckBox.h
> >  libs/koreport/renderer/odt/KoSimpleOdtCheckBox.cpp
> > 
> > KoOdtFrameReportCheckBox
> > 
> >  libs/koreport/renderer/odt/KoSimpleOdtDocument.h
> >  libs/koreport/renderer/odt/KoSimpleOdtDocument.cpp
> > 
> > KoOdtFrameReportDocument
> > 
> >  libs/koreport/renderer/odt/KoSimpleOdtImage.h
> >  libs/koreport/renderer/odt/KoSimpleOdtImage.cpp
> > 
> > KoOdtFrameReportImage
> > 
> >  libs/koreport/renderer/odt/KoSimpleOdtLine.h
> >  libs/koreport/renderer/odt/KoSimpleOdtLine.cpp
> > 
> > KoOdtFrameReportLine
> > 
> >  libs/koreport/renderer/odt/KoSimpleOdtPicture.h
> >  libs/koreport/renderer/odt/KoSimpleOdtPicture.cpp
> > 
> > KoOdtFrameReportPicture
> > 
> >  libs/koreport/renderer/odt/KoSimpleOdtPrimitive.h
> >  libs/koreport/renderer/odt/KoSimpleOdtPrimitive.cpp
> > 
> > KoOdtFrameReportTextBox
> > 
> >  libs/koreport/renderer/odt/KoSimpleOdtTextBox.h
> >  libs/koreport/renderer/odt/KoSimpleOdtTextBox.cpp
> > 
> >  libs/koreport/renderer/odt/ReportODTRenderer.h
> > 
> > KoOdtFrameReportImage
> > 
> > PS: After this improvement we would be able to rename Adam's renderer classes to KoOdtTableReport* 
> > and move them to libs/koreport/renderer/odttable.
> >
> 
> Dag Andersen wrote:
>     Done
> 
> Jarosław Staniek wrote:
>     Thanks, can I see the updated patch?
>     
>     I also have question about testing. In the light of our new code review rules, can we accept this new feature when testing was done with one app instead of two (i.e. without Kexi)?
> 
> Adam Pigg wrote:
>     I guess there is no impact on Kexi until we enable use of this output format?

Adam, no there's no impact. But the reason of moving a feature to shared libs area is to actually... share it. So either we validate the design being reviewed here by adding use for Kexi too in this patch directly or we declare that after committing we add Kexi support sooner than later. This would enable convenient validation.


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104797/#review13562
-----------------------------------------------------------


On April 30, 2012, 4:31 p.m., Dag Andersen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104797/
> -----------------------------------------------------------
> 
> (Updated April 30, 2012, 4:31 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Adam Pigg.
> 
> 
> Description
> -------
> 
> Changes is in branch: report_odt_danders
> 
> Move plans odt export into libs/koreport.
> 
> Retains the current odt export in koreport (as odttables) and
> adds the new as odtframes.
> 
> Patch includes modifications to Plan to enable use of both formats.
> 
> 
> Diffs
> -----
> 
>   libs/koreport/CMakeLists.txt d0737c9 
>   libs/koreport/renderer/KoReportODTRenderer2.h PRE-CREATION 
>   libs/koreport/renderer/KoReportODTRenderer2.cpp PRE-CREATION 
>   libs/koreport/renderer/KoReportRendererBase.cpp 497177d 
>   libs/koreport/renderer/odt/KoSimpleOdtCheckBox.h PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtCheckBox.cpp PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtDocument.h PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtDocument.cpp PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtImage.h PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtImage.cpp PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtLine.h PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtLine.cpp PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtPicture.h PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtPicture.cpp PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtPrimitive.h PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtPrimitive.cpp PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtTextBox.h PRE-CREATION 
>   libs/koreport/renderer/odt/KoSimpleOdtTextBox.cpp PRE-CREATION 
>   libs/koreport/renderer/odt/ReportODTRenderer.h PRE-CREATION 
>   plan/libs/ui/CMakeLists.txt 4948bd3 
>   plan/libs/ui/reports/odt/KoSimpleOdtCheckBox.h 94123e2 
>   plan/libs/ui/reports/odt/KoSimpleOdtCheckBox.cpp 9a94f5b 
>   plan/libs/ui/reports/odt/KoSimpleOdtDocument.h 65bbbee 
>   plan/libs/ui/reports/odt/KoSimpleOdtDocument.cpp 7d917ef 
>   plan/libs/ui/reports/odt/KoSimpleOdtImage.h 3c40922 
>   plan/libs/ui/reports/odt/KoSimpleOdtImage.cpp 1061664 
>   plan/libs/ui/reports/odt/KoSimpleOdtLine.h 6ea097b 
>   plan/libs/ui/reports/odt/KoSimpleOdtLine.cpp 2347117 
>   plan/libs/ui/reports/odt/KoSimpleOdtPicture.h 10c3b85 
>   plan/libs/ui/reports/odt/KoSimpleOdtPicture.cpp e0df27f 
>   plan/libs/ui/reports/odt/KoSimpleOdtPrimitive.h 7cff1c7 
>   plan/libs/ui/reports/odt/KoSimpleOdtPrimitive.cpp ddea498 
>   plan/libs/ui/reports/odt/KoSimpleOdtTextBox.h 428dff7 
>   plan/libs/ui/reports/odt/KoSimpleOdtTextBox.cpp d775689 
>   plan/libs/ui/reports/odt/ReportODTRenderer.h 3c9f149 
>   plan/libs/ui/reports/odt/ReportODTRenderer.cpp 2c95ed2 
>   plan/libs/ui/reports/report.h 8cef5be 
>   plan/libs/ui/reports/reportexportpanel.cpp 973078d 
>   plan/libs/ui/reports/reportview.h 265080a 
>   plan/libs/ui/reports/reportview.cpp dea21a6 
> 
> Diff: http://git.reviewboard.kde.org/r/104797/diff/
> 
> 
> Testing
> -------
> 
> Tested with Plan, resulting files opened with Words.
> 
> 
> Thanks,
> 
> Dag Andersen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120509/d6837d96/attachment.htm>

More information about the calligra-devel mailing list