Review Request: Support for path-stretchpoint-x and path-stretchpoint-y

Thorsten Zachmann t.zachmann at zagge.de
Wed May 9 04:45:22 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104804/#review13598
-----------------------------------------------------------


I have taken another run. In total it looks quite good however there are 3 files which seems to be wrong after the patch. Stangely it contains a object that was nearly the same as the last time and that was fixed.

I have uploaded the files to http://www.zagge.de/anchor/stretch/

hench-maths.wikispaces.com%2Ffile%2Fview%2FAdding+and+Subtracting+Fractions.ppt

On slide 2 the house is deformed.

www.setoolbelt.org%2Fsystem%2Ffiles%2Fresources%2FTOCs_and_Logic_Models_forAEA_1%30%309_1%30%309.odp

On slide 1 the rounding next to the line is to short. Also it seems to be no longer possible to resize the shape in question. (Please note that you need to unlock the page to ungroup and change the object). Without the patch the shape looks ok and can be resized. Also with the patch the object from the last review can be resized without problems.

www.usa.gov%2Fwebcontent%2Fdocuments%2FMachine%20Readable%20-%20Server.ppt

On slide 7 the info i seems to be doubled


- Thorsten Zachmann


On May 8, 2012, 11:20 a.m., Elvis Stansvik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104804/
> -----------------------------------------------------------
> 
> (Updated May 8, 2012, 11:20 a.m.)
> 
> 
> Review request for Calligra, Matus Hanzes, Thorsten Zachmann, and C. Boemann.
> 
> 
> Description
> -------
> 
> This patch adds support for path-stretchpoint-x and path-stretchpoint-y to the enhanced path shape. All credit for the patch goes to Matus. I simply found it at [1] where it seems to have been forgotten (filed against KOffice by mistake?).
> 
> [1] https://svn.reviewboard.kde.org/r/5978
> 
> 
> This addresses bug 258267.
>     http://bugs.kde.org/show_bug.cgi?id=258267
> 
> 
> Diffs
> -----
> 
>   plugins/pathshapes/enhancedpath/EnhancedPathShape.h 1919bb1 
>   plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp dc29c3a 
> 
> Diff: http://git.reviewboard.kde.org/r/104804/diff/
> 
> 
> Testing
> -------
> 
> I tested it with the document in bug 258267.
> 
> 
> Thanks,
> 
> Elvis Stansvik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120509/86626a7a/attachment-0001.html>


More information about the calligra-devel mailing list