Review Request: sure new name for style is unique
mojtaba shahi
mojtaba.shahi3000 at gmail.com
Tue May 8 19:26:56 BST 2012
> On May 8, 2012, 2:56 p.m., C. Boemann wrote:
> > plugins/textshape/dialogs/StyleManagerDialog.cpp, line 63
> > <http://git.reviewboard.kde.org/r/104882/diff/1/?file=63646#file63646line63>
> >
> > Same thing as in reject.
> >
> > In fact i'm not even sure it's needed to handle the close event. Im pretty sure it automatically calls reject()
i dont know but i tested . first it close the dialog and then call reject.
> On May 8, 2012, 2:56 p.m., C. Boemann wrote:
> > plugins/textshape/dialogs/StyleManagerDialog.cpp, line 53
> > <http://git.reviewboard.kde.org/r/104882/diff/1/?file=63646#file63646line53>
> >
> > hmm, while I agree we should warn, the user trying to leave unapplied changes it should be a choise dialog.
> >
> > And it shouldn't be just changing the name but any change.
so after user leaves page unapplying i should remove the altered style !!!!????
- mojtaba
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104882/#review13578
-----------------------------------------------------------
On May 7, 2012, 10:21 p.m., mojtaba shahi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104882/
> -----------------------------------------------------------
>
> (Updated May 7, 2012, 10:21 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> when you add new style or when you change name of style, patch checks that the new name for
>
> style is unique. patch doesnt let you to go another style or close dialog or apply and ok until the name
>
> that you have choosen for your style be unique.
>
>
> Diffs
> -----
>
> plugins/textshape/dialogs/StyleManager.h 44dff97
> plugins/textshape/dialogs/StyleManager.cpp c318dd7
> plugins/textshape/dialogs/CharacterGeneral.h bb72b88
> plugins/textshape/dialogs/CharacterGeneral.cpp 4923087
> plugins/textshape/dialogs/ParagraphGeneral.h 5ef5c86
> plugins/textshape/dialogs/ParagraphGeneral.cpp 8ef5b7f
> plugins/textshape/dialogs/StyleManagerDialog.h 56e36b4
> plugins/textshape/dialogs/StyleManagerDialog.cpp d423ae0
> plugins/textshape/dialogs/StylesModel.h 53c0225
> plugins/textshape/dialogs/StylesModel.cpp 3b03f1b
>
> Diff: http://git.reviewboard.kde.org/r/104882/diff/
>
>
> Testing
> -------
>
> it is ok and works right :)
>
>
> Thanks,
>
> mojtaba shahi
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120508/c5692f5f/attachment.htm>
More information about the calligra-devel
mailing list