Review Request: Fix Bug 284260 - Some text formatting is ignored for text-on-shape
Gopalakrishna Bhat
gopalakbhat at gmail.com
Sat May 5 07:39:16 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104813/
-----------------------------------------------------------
(Updated May 5, 2012, 6:39 a.m.)
Review request for Calligra.
Changes
-------
Fixed the comments mentioned by Zagge on IRC.
1) While saving, use the the alignment that is stored in the document instead of reading from the variable
2) Update the patch to affect the changes to all classes that derive from KoTosContainer i.e KoPathShape and PictureShape
Description
-------
We used to ignore the vertical and horizontal alignment for Enhanced path shape. This patch fixes that issue.
This addresses bugs 284260 and 288047.
http://bugs.kde.org/show_bug.cgi?id=284260
http://bugs.kde.org/show_bug.cgi?id=288047
Diffs (updated)
-----
libs/flake/KoPathShape.cpp 83eb24f
libs/flake/KoTosContainer.h 93d7493
libs/flake/KoTosContainer.cpp e6a3539
libs/flake/KoTosContainer_p.h 48fff5d
plugins/pictureshape/PictureShape.cpp e7fcd39
Diff: http://git.reviewboard.kde.org/r/104813/diff/
Testing
-------
Loaded the document in the bug report and checked
Thanks,
Gopalakrishna Bhat
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120505/303a7cb4/attachment.htm>
More information about the calligra-devel
mailing list