Review Request: Make Author information configurable on a settings level

C. Boemann cbr at boemann.dk
Thu May 3 21:25:31 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104843/
-----------------------------------------------------------

(Updated May 3, 2012, 8:25 p.m.)


Review request for Calligra.


Changes
-------

Added the dialog page to krita,karbon and sheets too

Words doesn't have such a dialo to put it in - yet
Anyone else would have to do it to their own app


Description
-------

   Make Author information configurable on a settings level
    The Document Information dialog's Author tab becomes read only and just shows who
    last saved the document.
    The author information is shared across all calligra apps
    KoPageApp is the only app so far to show the new settings page

this implements wish/bug https://bugs.kde.org/show_bug.cgi?id=260469

It also solves the bug (no number) that save cycles number was never incremented


Diffs (updated)
-----

  karbon/ui/dialogs/KarbonConfigureDialog.h 9a591d7 
  karbon/ui/dialogs/KarbonConfigureDialog.cpp b7a45b1 
  krita/ui/dialogs/kis_dlg_preferences.cc 8cbcddf 
  libs/kopageapp/dialogs/KoPAConfigureDialog.h 0cd71f5 
  libs/kopageapp/dialogs/KoPAConfigureDialog.cpp b7f577c 
  libs/main/CMakeLists.txt 2eb3681 
  libs/main/KoDocumentInfo.h 5fe8e21 
  libs/main/KoDocumentInfo.cpp dff3255 
  libs/main/KoDocumentInfoDlg.h cf619a2 
  libs/main/KoDocumentInfoDlg.cpp 4073a8c 
  libs/main/config/KoConfigAuthorPage.h PRE-CREATION 
  libs/main/config/KoConfigAuthorPage.cpp PRE-CREATION 
  libs/main/config/KoConfigAuthorPage.ui PRE-CREATION 
  libs/main/koDocumentInfoAuthorWidget.ui c9137b2 
  sheets/part/dialogs/PreferenceDialog.cpp 2bf53c4 

Diff: http://git.reviewboard.kde.org/r/104843/diff/


Testing
-------


Thanks,

C. Boemann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120503/94c8ff89/attachment.htm>


More information about the calligra-devel mailing list