Review Request: Don't change size of pictureshape after setting a new image

Sven Langkamp sven.langkamp at gmail.com
Tue May 1 23:50:28 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104819/
-----------------------------------------------------------

(Updated May 1, 2012, 10:50 p.m.)


Review request for Calligra.


Changes
-------

Updated diff to also fix the bug.


Description
-------

The patch fixes bug 285897. Problem is that the pictureshape shouldn't change the size as that could affect the rest of the document. This is fixed by not changing the size in the image change command.


This addresses bug 285897.
    http://bugs.kde.org/show_bug.cgi?id=285897


Diffs (updated)
-----

  plugins/pictureshape/ChangeImageCommand.h 516061b 
  plugins/pictureshape/ChangeImageCommand.cpp 40e2d4c 
  plugins/pictureshape/PictureShapeConfigWidget.cpp c532823 

Diff: http://git.reviewboard.kde.org/r/104819/diff/


Testing
-------

Tested opening a new picture and size stays the same.


Thanks,

Sven Langkamp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120501/8a64ab56/attachment.htm>


More information about the calligra-devel mailing list