Review Request: Support for path-stretchpoint-x and path-stretchpoint-y

C. Boemann cbr at boemann.dk
Tue May 1 15:49:22 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104804/#review13219
-----------------------------------------------------------


I only have some stylistic stuff.

And the code as a whole looks nicely written and from a known good coder (no longer active in calligra)

As for the content itself, i do'nt even know what stretchpoints is - so over to someone else :)



plugins/pathshapes/enhancedpath/EnhancedPathShape.h
<http://git.reviewboard.kde.org/r/104804/#comment10345>

    trailing space



plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp
<http://git.reviewboard.kde.org/r/104804/#comment10346>

    please add space after ,



plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp
<http://git.reviewboard.kde.org/r/104804/#comment10347>

    just wondering if there is a reason for not using foreach in these two places.
    I know it's not your code, so just wondering out loud



plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp
<http://git.reviewboard.kde.org/r/104804/#comment10348>

    add spaces either side of /


- C. Boemann


On May 1, 2012, 10:48 a.m., Elvis Stansvik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104804/
> -----------------------------------------------------------
> 
> (Updated May 1, 2012, 10:48 a.m.)
> 
> 
> Review request for Calligra, Matus Hanzes, Thorsten Zachmann, and C. Boemann.
> 
> 
> Description
> -------
> 
> This patch adds support for path-stretchpoint-x and path-stretchpoint-y to the enhanced path shape. All credit for the patch goes to Matus. I simply found it at [1] where it seems to have been forgotten (filed against KOffice by mistake?).
> 
> [1] https://svn.reviewboard.kde.org/r/5978
> 
> 
> This addresses bug 258267.
>     http://bugs.kde.org/show_bug.cgi?id=258267
> 
> 
> Diffs
> -----
> 
>   plugins/pathshapes/enhancedpath/EnhancedPathShape.h 1919bb1 
>   plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp dc29c3a 
> 
> Diff: http://git.reviewboard.kde.org/r/104804/diff/
> 
> 
> Testing
> -------
> 
> I tested it with the document in bug 258267.
> 
> 
> Thanks,
> 
> Elvis Stansvik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120501/972f8a20/attachment.html>


More information about the calligra-devel mailing list