Review Request: Fix bug 278419: Setting a text box as Read Only allows changes to be made nevertheles

[Jarosław Staniek]

> On March 30, 2012, 9:04 p.m., Adam Pigg wrote:
> > kexi/plugins/forms/widgets/kexidblineedit.cpp, line 274
> > <http://git.reviewboard.kde.org/r/104434/diff/1/?file=55117#file55117line274>
> >
> >     why is it necessary to special case here?  will there be other special cases?

Please look at my comment here https://bugs.kde.org/show_bug.cgi?id=278419#c1
Readonly needs this special validator.


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104434/#review12039
-----------------------------------------------------------


On March 28, 2012, 10:20 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104434/
> -----------------------------------------------------------
> 
> (Updated March 28, 2012, 10:20 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg and Dimitrios Tanis.
> 
> 
> Description
> -------
> 
> Kexi Forms
> *Fixed bug: Setting a text box as Read Only allows changes to be made nevertheles
> 
> Extra
> *Properly updated context menu when read-only flag is set for line edits and text boxes
> 
> 
> This addresses bug 278419.
>     http://bugs.kde.org/show_bug.cgi?id=278419
> 
> 
> Diffs
> -----
> 
>   kexi/doc/dev/CHANGELOG-Kexi-js 5ef0980 
>   kexi/plugins/forms/widgets/kexidblineedit.h 31c49a6 
>   kexi/plugins/forms/widgets/kexidblineedit.cpp a669cbb 
>   kexi/plugins/forms/widgets/kexidbtextedit.h b6320d9 
>   kexi/plugins/forms/widgets/kexidbtextedit.cpp 0de5989 
>   kexi/plugins/forms/widgets/kexidbutils.h 28bf749 
>   kexi/plugins/forms/widgets/kexidbutils.cpp 7cec3b5 
>   kexi/widget/utils/kexicontextmenuutils.cpp 4a244c4 
> 
> Diff: http://git.reviewboard.kde.org/r/104434/diff/
> 
> 
> Testing
> -------
> 
> Using readonly line edits and multiline text boxes; trying editing actions, shortcuts and context menu actions
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120330/9cb07dea/attachment.htm>