Review Request: Fix wrongly always present dot behind bullet in preview of the Paragraph dialog
Gopalakrishna Bhat
gopalakbhat at gmail.com
Thu Mar 29 23:20:43 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104411/#review11993
-----------------------------------------------------------
I think that it can be committed to master and 2.4.
- Gopalakrishna Bhat
On March 26, 2012, 6:52 a.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104411/
> -----------------------------------------------------------
>
> (Updated March 26, 2012, 6:52 a.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> The preview of the Paragraph settings dialog always shows a . behind the bullet item, also for non-numeric bullet types, if no prefix is set.
> In the document things seems fine, it seems just the dialog which behaves not well... bad, bad dialog... :)
>
> For RTL types there might be another issue, but not really related. And I have no reap experience with that. Just mentioning, in case the reviewer wants to do something about it now she is looking at the code ;)
>
> Okay to backport to 2.4?
>
>
> Diffs
> -----
>
> plugins/textshape/dialogs/ParagraphBulletsNumbers.cpp 7964a7d
>
> Diff: http://git.reviewboard.kde.org/r/104411/diff/
>
>
> Testing
> -------
>
> Tried various bullet settings, no problem seen.
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120329/fe1066d6/attachment.htm>
More information about the calligra-devel
mailing list