Review Request: Align toolbox behaviour in all Calligra programs (or: enable single column of buttons in Stage/Flow/Sheets)

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104426/#review11946
-----------------------------------------------------------


This review has been submitted with commit a92126d62b064f2c71a7433ed37fc85d6f3d37a9 by Friedrich W. H. Kossebau to branch master.

- Commit Hook


On March 27, 2012, 12:20 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104426/
> -----------------------------------------------------------
> 
> (Updated March 27, 2012, 12:20 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> In Stage, Flow, Sheets it is not possible to make the toolbox that small that there is only a single column of buttons.
> In Krita and Karbon it is possible.
> In Stage, Flow, Sheets this results in a lot of unused screen real estate on the (default) right side.
> 
> Reason is that the KoDockWidgetTitleBar calculates the minimal width by including the full width of the title.
> Krita and Karbon seem to work around that by setting the title to " "... tss ;)
> But this workaround results in an empty title in the dock widgets title context menu (see by RMB on dockwidget title).
> 
> Attached patch changes this, by:
> * making the minimal width of the KoDockWidgetTitleBar optionally depending on the text width
> * setting the title of the toolbox dockwidget always to "Tools"
> * showing a tooltip with the title name for the toolbox dockwidget
> 
> Commits which make this patch have the titles:
>    Changed: no need to set KoDockWidgetTitleBar::ignoreTextSize to false in KoToolBoxDocker, is false by default
>    Removed: unused methods KoDockWidgetTitleBar::setTextVisible/setIgnoreTextSize
>    Changed: no need to explicitely set toolbox title to "Tools", is default name
>    Added: TextVisibilityMode for KoDockWidgetTitleBar
>    Changes: align toolbox behaviour for all Calligra programs
> 
> 
> Diffs
> -----
> 
>   braindump/src/View.cpp baed830 
>   karbon/ui/KarbonView.cpp c02e954 
>   krita/ui/kis_view2.cpp e357284 
>   libs/kopageapp/KoPAView.cpp ade6916 
>   libs/main/KoToolBoxDocker.cpp e6e3dc6 
>   libs/main/KoToolBoxDocker_p.h 3cfc370 
>   libs/main/KoToolBoxFactory.h 5567349 
>   libs/main/KoToolBoxFactory.cpp b3854f6 
>   libs/widgets/KoDockWidgetTitleBar.h c018e9a 
>   libs/widgets/KoDockWidgetTitleBar.cpp fe62390 
>   sheets/part/View.cpp 5bb6acd 
> 
> Diff: http://git.reviewboard.kde.org/r/104426/diff/
> 
> 
> Testing
> -------
> 
> Played around with the toolbox in Stage, Flow, Sheets, Krita and Karbon, by resizing it, moving to other places and using tools.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120328/a592d5c9/attachment.htm>