[calligra] /: Move insert pagebreak handling from Words to texttool

[C. Boemann]

On Wednesday 28 March 2012 06:14:11 Thorsten Zachmann wrote:
> Hello,
> 
> On Tuesday, March 27, 2012 20:04:06 C. Boemann wrote:
> > Okay to backport to 2.4 ?
> > 
> > On Tuesday 27 March 2012 20:00:37 C. Boemann wrote:
> > > Git commit 4e778319817bec12a4b53877f5a2b42ed0448131 by C. Boemann.
> > > Committed on 27/03/2012 at 19:36.
> > > Pushed by boemann into branch 'master'.
> > > 
> > > Move insert pagebreak handling from Words to texttool
> > > And also fix that view doesn't move when inserting text or pagebreak
> > > that casuses the new position to be visible.
> > > BUG: 296891
> > > 
> > > M  +22   -1    plugins/textshape/TextTool.cpp
> > > M  +2    -0    plugins/textshape/TextTool.h
> > > M  +3    -22   words/part/KWView.cpp
> > > M  +0    -2    words/part/KWView.h
> > > 
> > > http://commits.kde.org/calligra/4e778319817bec12a4b53877f5a2b42ed044813
> > > 1
> 
> Not sure if adding of a commented out i18n does not break the string
> freeze. Would it be possible to set the string of the command in words on
> the action so we will not loose the string for 2.4?
> 
> Thorsten
> _______________________________________________
> calligra-devel mailing list
> calligra-devel at kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel
I accidentally pushed it already to 2.4, but loosing the string doesn't 
matter, as it wasn't visible anywhere anyway (well unless the user edited the 
.rc file)

So you think adding the commented out i18n line adds the string anyway. Yeah I 
can see how that may be the case. Well as it's not visible it doesn't matter 
if the translators doesn't make it.