Review Request: Rename class KoLineBorder -> KoShapeStroke

Inge Wallin inge at lysator.liu.se
Tue Mar 27 01:53:49 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104421/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

This is the continuation of my last two patches. It renames the KoLineBorder class in libs/flake to KoShapeStroke. I would have preferred KoStroke since it doesn't have anything to do with shapes per se, but a) it's in libs/flake, not libs/odf and b) the other similar classes had KoShape... names like KoShapeBackground and KoShapeShadow.


Diffs
-----

  filters/karbon/wmf/WmfExport.cpp 47ff598 
  karbon/common/KarbonOutlinePaintingStrategy.h f29d799 
  karbon/common/KarbonOutlinePaintingStrategy.cpp ef338df 
  karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyTool.cpp c861e0d 
  karbon/plugins/tools/KarbonGradientEditStrategy.h a4d5e99 
  karbon/plugins/tools/KarbonGradientEditStrategy.cpp 36725af 
  karbon/plugins/tools/KarbonGradientTool.cpp a4d6ebb 
  karbon/plugins/tools/KarbonPencilTool.h 0f26da3 
  karbon/plugins/tools/KarbonPencilTool.cpp 8180faa 
  karbon/ui/KarbonView.cpp c02e954 
  karbon/ui/widgets/KarbonPaletteBarWidget.cpp 15a4696 
  karbon/ui/widgets/KarbonSmallStylePreview.cpp f03d68d 
  libs/flake/CMakeLists.txt fc515db 
  libs/flake/KoCanvasResourceManager.h 163ba6f 
  libs/flake/KoCanvasResourceManager.cpp af07357 
  libs/flake/KoConnectionShapeFactory.cpp b0b4f0b 
  libs/flake/KoDocumentResourceManager.h 4396aea 
  libs/flake/KoFlake.cpp 81dc117 
  libs/flake/KoPathShape.cpp 5fa931f 
  libs/flake/KoPathShapeFactory.cpp 663dd5c 
  libs/flake/KoResourceManager_p.cpp 2967b6f 
  libs/flake/KoShape.cpp 511b54d 
  libs/flake/KoShapeStroke.h 27da450 
  libs/flake/KoShapeStroke.cpp 04d5a7b 
  libs/flake/svg/SvgGraphicContext.h 9f08241 
  libs/flake/svg/SvgParser.cpp f0d4c03 
  libs/flake/svg/SvgStyleWriter.cpp cf4fb71 
  libs/flake/tests/TestShapeAt.cpp d07eb1c 
  libs/flake/tests/TestShapeGroupCommand.cpp c5bf2a2 
  libs/flake/tests/TestShapeStrokeCommand.cpp d300180 
  libs/flake/tools/KoCreatePathTool.h 770f3ec 
  libs/flake/tools/KoCreatePathTool.cpp 4d3142b 
  libs/kopageapp/KoPADocument.cpp afcde61 
  libs/widgets/KoStrokeConfigWidget.h e80c434 
  libs/widgets/KoStrokeConfigWidget.cpp 2fa69a9 
  plugins/artistictextshape/ArtisticTextTool.cpp 492ba6f 
  plugins/chartshape/ChartShape.cpp ddc5eab 
  plugins/chartshape/Legend.cpp 561eeca 
  plugins/commentshape/CommentShape.cpp a1adca87 
  plugins/defaultTools/connectionTool/ConnectionTool.cpp 58ce99f 
  plugins/dockers/strokedocker/StrokeDocker.cpp fc4d8c2 
  plugins/dockers/styledocker/StyleDocker.cpp e11a2bf 
  plugins/pathshapes/ellipse/EllipseShapeFactory.cpp 5a20373 
  plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp d2dcfe4 
  plugins/pathshapes/rectangle/RectangleShapeFactory.cpp d7b7427 
  plugins/pathshapes/spiral/SpiralShapeFactory.cpp c304999 
  plugins/pathshapes/star/StarShapeFactory.cpp aa91bd3 

Diff: http://git.reviewboard.kde.org/r/104421/diff/


Testing
-------

I tested with most ways I could change strokes and I couldn't find any new bugs.


Thanks,

Inge Wallin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120327/68cda06b/attachment.htm>


More information about the calligra-devel mailing list