Review Request: Remove some unnecessary classes in libs/flake

Inge Wallin inge at lysator.liu.se
Mon Mar 26 17:22:13 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104415/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

The three classes KoLineBorderFactory, KoShapeBorderFactoryBase and KoShapeBorderRegistry are not used anywhere at all, which can be seen by the minimal diff.

I suggest to just remove them.  The factory does nothing else than 'new KoLineBorder;', and the factory base is not inherited anywhere else. Noteworthy is that there are no similar classes for the other common shape attributes Fill and Shadow.


Diffs
-----

  libs/flake/CMakeLists.txt 28e778f 

Diff: http://git.reviewboard.kde.org/r/104415/diff/


Testing
-------

Not much testing for this one except building and installing.


Thanks,

Inge Wallin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120326/67ac38e1/attachment.htm>


More information about the calligra-devel mailing list