Review Request: Fix wrongly always present dot behind bullet in preview of the Paragraph dialog

[Gopalakrishna Bhat]

> On March 26, 2012, 7:01 a.m., Pierre Stirnweiss wrote:
> > This preview will have to go rather soonish. What needs to be done here is to replace the whole preview with a thumbnail created by the KoStyleThumbnailer (in the textlayout lib).
> > That way, the preview is really using the same layout/drawing stuff as the shapes. Now it is all done specific to this preview.

Yeah. It needs to be replaced by the thumbnail from KoStyleThumbnailer. I was planning to do this change after the 2.4 branching. Now that it is done, just have to find time for doing the changes. 


- Gopalakrishna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104411/#review11866
-----------------------------------------------------------


On March 26, 2012, 6:52 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104411/
> -----------------------------------------------------------
> 
> (Updated March 26, 2012, 6:52 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> The preview of the Paragraph settings dialog always shows a . behind the bullet item, also for non-numeric bullet types, if no prefix is set.
> In the document things seems fine, it seems just the dialog which behaves not well... bad, bad dialog... :)
> 
> For RTL types there might be another issue, but not really related. And I have no reap experience with that. Just mentioning, in case the reviewer wants to do something about it now she is looking at the code ;)
> 
> Okay to backport to 2.4?
> 
> 
> Diffs
> -----
> 
>   plugins/textshape/dialogs/ParagraphBulletsNumbers.cpp 7964a7d 
> 
> Diff: http://git.reviewboard.kde.org/r/104411/diff/
> 
> 
> Testing
> -------
> 
> Tried various bullet settings, no problem seen.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120326/9daaf59a/attachment.htm>