Review Request: remove wide left margin from KoModeBox

[Friedrich W. H. Kossebau]

> On March 25, 2012, 11:42 p.m., C. Boemann wrote:
> > If you change it to setFrameShadow you can commit that one line.

Ah, indeed used the wrong call, should have been setFrameShadow(..). Just the order of calls did not show the error.
Then a single
    s->setFrameStyle(QFrame::HLine | QFrame::Sunken);
is less code than two explicit 
    s->setFrameShadow(QFrame::Sunken);
    s->setFrameShape(QFrame::HLine);

Which version do you prefer? (and why, just to learn about your reasoning, am fine with whatever you like more)


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104409/#review11851
-----------------------------------------------------------


On March 25, 2012, 11:26 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104409/
> -----------------------------------------------------------
> 
> (Updated March 25, 2012, 11:26 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> I have found the wider empty margin on the left side of the KoModeBox as e.g. used in the Words UI to be not perfect, stealing some space on the screen.
> 
> What about the attached patch, which removes the margin, also makes the line separators sunken, so they look nicer with non-Oxygen styles as well.
> 
> For pictures see the attached file, e.g. view in gwenview using the arrow keys to see the difference.
> 
> Okay to forward port to master?
> 
> 
> Diffs
> -----
> 
>   libs/main/KoModeBox.cpp 281a768 
> 
> Diff: http://git.reviewboard.kde.org/r/104409/diff/
> 
> 
> Testing
> -------
> 
> Used a little bit.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120325/2e3af5c5/attachment.htm>