Review Request: remove wide left margin from KoModeBox

[Friedrich W. H. Kossebau]

> On March 25, 2012, 11:32 p.m., C. Boemann wrote:
> > hmm no, the indentation is on purpose
> > 
> > as for the sunken it may be ok, but i'll have to test it first

guessed that the indentation is on purpose :) but it is really quite wide IMHO.
Surely QToolBox is also not the nicest widget around, by the current implementation, think the trolls dropped any effort on it too quickly. :/

Okay, just a proposal, not that I thought that was a perfect solution, being a little bit less easy for the eye than what there is currently. No win-win.


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104409/#review11849
-----------------------------------------------------------


On March 25, 2012, 11:26 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104409/
> -----------------------------------------------------------
> 
> (Updated March 25, 2012, 11:26 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> I have found the wider empty margin on the left side of the KoModeBox as e.g. used in the Words UI to be not perfect, stealing some space on the screen.
> 
> What about the attached patch, which removes the margin, also makes the line separators sunken, so they look nicer with non-Oxygen styles as well.
> 
> For pictures see the attached file, e.g. view in gwenview using the arrow keys to see the difference.
> 
> Okay to forward port to master?
> 
> 
> Diffs
> -----
> 
>   libs/main/KoModeBox.cpp 281a768 
> 
> Diff: http://git.reviewboard.kde.org/r/104409/diff/
> 
> 
> Testing
> -------
> 
> Used a little bit.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120325/1288e8b7/attachment.htm>