Review Request: Improve the layout of KoPageLayoutWidget and KWDocumentColumns, also add margins to print option pages
Friedrich W. H. Kossebau
kossebau at kde.org
Thu Mar 22 21:52:21 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104370/
-----------------------------------------------------------
Review request for Calligra, C. Boemann and Dag Andersen.
Description
-------
Small improvements (?) to things which jumped into my eyes a few times meanwhile.
* Changed: printing option widgets need to have outer margins set, due to being set to a tab page
* Changed: no need to set margins of KoPageLayoutWidget object to 0, is by default
* Changed: improve layout of KWDocumentColumns by using a QFormLayout
* Changed: make labels of KoPageLayoutWidget right-aligned, improve resize behaviour
Not sure if KoPageLayoutWidget should be resizable/enlargable at all, but it's consistent to other UIs,
so I have implemented some nicer enlarging behaviour there.
Okay to backport all to 2.4?
Diffs
-----
libs/main/KoMainWindow.cpp 627d763
libs/widgets/KoPageLayoutDialog.cpp 7eaeb6a
libs/widgets/KoPageLayoutWidget.ui b36e080
plan/libs/ui/kptganttprintingoptions.ui 2d9d85b
plan/libs/ui/kptviewbase.cpp 90bbad5
words/part/dialogs/KWDocumentColumns.ui 56e58ca
words/part/dialogs/KWStartupWidget.cpp a0a43ac
Diff: http://git.reviewboard.kde.org/r/104370/diff/
Testing
-------
Used all the UIs touched and resized them a few times.
Thanks,
Friedrich W. H. Kossebau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120322/fc4787bf/attachment.htm>
More information about the calligra-devel
mailing list