warning C4129: '%' : unrecognized character escape sequence

Andrius da Costa Ribas andriusmao at gmail.com
Sun Mar 18 03:52:50 GMT 2012


Please find attached the patch for 2.4 branch (Either reviewboard does not
accept patches for non-master or I don't know how to).

2012/3/17 Andrius da Costa Ribas <andriusmao at gmail.com>

> Hello,
>
> As discussed on IRC, some sources contains "\%" invalid escape sequence:
>
> filters/libmso/ODrawToOdf.cpp(625):         style.addAttribute("svg:x1",
> QString("%1\%").arg(x1));
> filters/libmso/ODrawToOdf.cpp(626):         style.addAttribute("svg:y1",
> QString("%1\%").arg(y1));
> filters/libmso/ODrawToOdf.cpp(627):         style.addAttribute("svg:x2",
> QString("%1\%").arg(x2));
> filters/libmso/ODrawToOdf.cpp(628):         style.addAttribute("svg:y2",
> QString("%1\%").arg(y2));
> filters/libmso/ODrawToOdf.cpp(680):         style.addAttribute("svg:x1",
> QString("%1\%").arg(x1));
> filters/libmso/ODrawToOdf.cpp(681):         style.addAttribute("svg:y1",
> QString("%1\%").arg(y1));
> filters/libmso/ODrawToOdf.cpp(682):         style.addAttribute("svg:x2",
> QString("%1\%").arg(x2));
> filters/libmso/ODrawToOdf.cpp(683):         style.addAttribute("svg:y2",
> QString("%1\%").arg(y2));
> filters/sheets/xlsx/ChartExport.cpp(240):
> style.addProperty( "draw:opacity", QString( "%1\%" ).arg(
> chart()->m_areaFormat->m_foreground.alphaF() * 100.0 ),
> KoGenStyle::GraphicType );
> filters/sheets/xlsx/ChartExport.cpp(302):
> style.addProperty( "draw:opacity", QString( "%1\%" ).arg(
> areaFormat->m_foreground.alphaF() * 100.0 ), KoGenStyle::GraphicType );
>
> Is it okay to just replace "\%" by "%" ?
>
> Thanks,
> Andrius.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120318/02190d71/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-invalid-escape-sequence.patch
Type: application/octet-stream
Size: 4552 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120318/02190d71/attachment.obj>


More information about the calligra-devel mailing list