Review Request: KoXmlWriter - don't add control codes not accepted in XML 1.0 documents.
Matus Uzak
matus.uzak at ixonos.com
Thu Mar 15 15:11:14 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104288/
-----------------------------------------------------------
Review request for Calligra, Thorsten Zachmann and C. Boemann.
Description
-------
We already skip those codes in the addTextSpan function but not in the escapeForXML function called by addTextNode. Especially binary data (doc/ppt/xls) can contain those, most often the NAK control code.
Diffs
-----
libs/odf/KoXmlWriter.cpp d51c61f
Diff: http://git.reviewboard.kde.org/r/104288/diff/
Testing
-------
Usual round with cstrunner on binary file formats.
A test file which contains a NAK: http://neuron.tuke.sk/~uzak/calligra/test-flipr-ses-2-5072.doc
Thanks,
Matus Uzak
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120315/6a7b2e3c/attachment.htm>
More information about the calligra-devel
mailing list