Review Request: Improvements in saving pie/ring charts

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104268/#review11390
-----------------------------------------------------------


The code looks fine. Tbh I don't really understand this code, it was written by Johannes Simon originally. I'm fine with committing it but I'll let Sebastian give the final "Ship it".

- Inge Wallin


On March 14, 2012, 6:53 a.m., Brijesh Patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104268/
> -----------------------------------------------------------
> 
> (Updated March 14, 2012, 6:53 a.m.)
> 
> 
> Review request for Calligra, Inge Wallin and Sebastian Sauer.
> 
> 
> Description
> -------
> 
> FIX : Changing chart type from pie/ring chart to bar chart or vice versa ,doesn't works as expected
> 
> i) checks whether the dataDirection is vertical or horizontal and then returns the brush 
>       - This fixes changing chart type from bar chart to pie/ring chart
> 
> ii) ensures that axis are saved no matter what be the chart type
>       - This fixes changing chart type from pie/ring chart to bar chart
> 
> 
> Diffs
> -----
> 
>   plugins/chartshape/DataSet.cpp 1ac5de3 
>   plugins/chartshape/PlotArea.cpp 8f2a9db 
> 
> Diff: http://git.reviewboard.kde.org/r/104268/diff/
> 
> 
> Testing
> -------
> 
> Tested using cstester on some test documents
> 
> 
> Thanks,
> 
> Brijesh Patel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120314/d37e9b50/attachment.htm>